Date: Mon, 25 Sep 2017 14:25:43 -0700 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Stephen Hurd <shurd@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r323944 - in head/sys: kern sys Message-ID: <20170925212543.GX1055@FreeBSD.org> In-Reply-To: <201709230139.v8N1dGCi063544@repo.freebsd.org> References: <201709230139.v8N1dGCi063544@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Stephen, On Sat, Sep 23, 2017 at 01:39:16AM +0000, Stephen Hurd wrote: S> Author: shurd S> Date: Sat Sep 23 01:39:16 2017 S> New Revision: 323944 S> URL: https://svnweb.freebsd.org/changeset/base/323944 S> S> Log: S> Make struct grouptask gt_name member a char array S> S> Previously, it was just a pointer which was copied, but S> some callers pass in a stack variable which will go out of scope. S> Add GROUPTASK_NAMELEN macro (32) and snprintf() the name into it, S> using "grouptask" if name is NULL. We can now safely include S> gtask->gt_name in console messages. Have you estimated which structures include struct grouptask, so that they now got larger? Is this done only for the sake of console messages? -- Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170925212543.GX1055>