Date: Thu, 6 Oct 2005 19:58:32 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Nate Lawson <nate@root.org> Cc: cvs-src@FreeBSD.org, Stefan Farfeleder <stefanf@FreeBSD.org>, cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/libkern strtok.c src/sys/sys libkern.h src/sys/conf files Message-ID: <20051006175832.GA26614@garage.freebsd.pl> In-Reply-To: <434560A7.2010603@root.org> References: <200510061110.j96BAApc034176@repoman.freebsd.org> <20051006132738.GG603@wombat.fafoe.narf.at> <20051006144454.GF23662@garage.freebsd.pl> <20051006154754.GH603@wombat.fafoe.narf.at> <434560A7.2010603@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--3V7upXqbjpZ4EhLz Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 06, 2005 at 10:36:39AM -0700, Nate Lawson wrote: +> Stefan Farfeleder wrote: +> >On Thu, Oct 06, 2005 at 04:44:54PM +0200, Pawel Jakub Dawidek wrote: +> >>On Thu, Oct 06, 2005 at 03:27:40PM +0200, Stefan Farfeleder wrote: +> >>+> On Thu, Oct 06, 2005 at 11:10:10AM +0000, Pawel Jakub Dawidek wrote: +> >>+> > pjd 2005-10-06 11:10:10 UTC +> >>+> > +> > FreeBSD src repository +> >>+> > +> > Modified files: +> >>+> > sys/sys libkern.h +> > sys/conf = files +> > Added files: +> >>+> > sys/libkern strtok.c +> > Log: +> >>+> > Add strtok() and strtok_r() function to libkern. +> >>+> +> Wouldn't it be better to have strsep() instead? +> >>Actually we do have strsep() libkern already... +> >Oops. Can you please change nfs_diskless.c to use strsep()? I think +> >it's a mistake to add non-reentrant functions to libkern. +> >Stefan +>=20 +> Agreed. I wanted to use it to parse options for NFS root file system. There is no race risk there, but I added also strtok_r() function. That was my thinking back then. I was wrong, I should look closer for strsep() in libkern and just use it. Sorry for the mess I'll back it out after some testing of setsep() version. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --3V7upXqbjpZ4EhLz Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFDRWXIForvXbEpPzQRAg4PAKC1e7GUo63kduOelHyTJRErBUIMOQCfUoCC luQlId7Tf1lBaIVQSE5tZgI= =fpto -----END PGP SIGNATURE----- --3V7upXqbjpZ4EhLz--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051006175832.GA26614>