Date: Mon, 28 Oct 2002 15:42:07 -0500 (EST) From: John Baldwin <jhb@FreeBSD.org> To: Jeff Roberson <jroberson@chesapeake.net> Cc: Nate Lawson <nate@root.org>, current@FreeBSD.ORG, Joe Marcus Clarke <marcus@marcuscom.com>, Terry Lambert <tlambert2@mindspring.com> Subject: Re: libgtop port and v_tag changes Message-ID: <XFMail.20021028154207.jhb@FreeBSD.org> In-Reply-To: <20021028152827.X62100-100000@mail.chesapeake.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 28-Oct-2002 Jeff Roberson wrote:
> On Mon, 28 Oct 2002, Terry Lambert wrote:
>
>> John Baldwin wrote:
>> > Yes. This means that you don't need to even look at v_tag to see
>> > if it is a UFS vnode or not. What does libgtop want with
>> > device and inode numbers anways? Does it actually do anything
>> > useful with them or does it just print them somewhere? Is a user
>> > going to care if the inode number was obtained from the vnode
>> > or if we groveled in the internals of UFS to find it?
>>
>> The user will, if they try to use "find -inum" to identify the
>> file name associated with it, since the vnode number is useless
>> for this purpose, and the inode number is not... particularly
>> if the information is being obtained from a log file.
>>
>
> Terry is right. It needs to be the same inode number that is reported by
> stat and getdirents. It's unfortunate that you can't do a getattr or stat
> based on the address of the vnode. I have actually used and relied on this
> behavior in the past. Not specifically with gtop though.
if ((error = VOP_GETATTR(vp, vap, cred, td)) == 0) {
vp->v_cachedfs = vap->va_fsid;
vp->v_cachedid = vap->va_fileid;
}
and the only other place it is set:
vap = &vattr;
error = VOP_GETATTR(vp, vap, active_cred, td);
if (error)
return (error);
vp->v_cachedfs = vap->va_fsid;
vp->v_cachedid = vap->va_fileid;
--
John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20021028154207.jhb>