Date: Mon, 6 Dec 2021 21:31:43 +0000 From: Jessica Clarke <jrtc27@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: ab4524b3d7fb - main - amd64: wrap 64bit sigtramp into vdso Message-ID: <E732DE85-529F-45B8-A875-FAB5C025CEA1@freebsd.org> In-Reply-To: <Ya6AZadt%2BY0ns0O2@kib.kiev.ua> References: <202112061848.1B6ImIf8065076@gitrepo.freebsd.org> <BDD795B9-F98E-48FC-BD89-10D3C5AE89AE@freebsd.org> <Ya6AZadt%2BY0ns0O2@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 6 Dec 2021, at 21:28, Konstantin Belousov <kostikbel@gmail.com> = wrote: >=20 > On Mon, Dec 06, 2021 at 08:51:02PM +0000, Jessica Clarke wrote: >> On 6 Dec 2021, at 18:48, Konstantin Belousov <kib@FreeBSD.org> wrote: >>>=20 >>> The branch main has been updated by kib: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dab4524b3d7fba872a143b03c9346cb04= c3670efa >>>=20 >>> commit ab4524b3d7fba872a143b03c9346cb04c3670efa >>> Author: Konstantin Belousov <kib@FreeBSD.org> >>> AuthorDate: 2021-11-05 08:07:24 +0000 >>> Commit: Konstantin Belousov <kib@FreeBSD.org> >>> CommitDate: 2021-12-06 18:46:49 +0000 >>>=20 >>> amd64: wrap 64bit sigtramp into vdso >>>=20 >>> Reviewed by: emaste >>> Discussed with: jrtc27 >>> Tested by: pho >>> Sponsored by: The FreeBSD Foundation >>> MFC after: 1 month >>> Differential revision: https://reviews.freebsd.org/D32960 >>=20 >> This broke cross-building from non-FreeBSD: >>=20 >>> ERROR: ctfconvert: elf-vdso.so.o doesn't have type data to convert >>=20 >> The error message also shows up on FreeBSD, but ctfconvert has a = gross >> #ifdef __FreeBSD__ hack in it to make it non-fatal (dating right back >> to when it was imported), which of course doesn=E2=80=99t work when = building on >> non-FreeBSD, and is something I=E2=80=99ve wanted to remove from = FreeBSD too as >> silently allowing broken CTF is a bad idea these days (see AArch64 >> where LLVM 13 bogusly emits DWARF using C++ constructs for C, = breaking >> CTF entirely, which wasn=E2=80=99t caught until it was built on = non-FreeBSD). >>=20 >> I imagine this just needs no-ctfconvert in files.amd64 for both = VDSOs? >=20 > I have no idea. If you think it is the right fix for your problem, go = ahead? > I doubt that vdso wrapper objects would ever carry anything that = resemble > type info, or that could be useful as the dtrace material. Sure, I have other cross-build changes to push too as the world isn=E2=80=99= t quite unbroken after the libdwarf change (Linux is happy now, but macOS isn=E2=80=99t due to libcrypt not being a thing there... whack-a-mole = continues). > BTW, we have enough .S files that do not generate any dwarf data. Why = is it > not a same problem? I imagine because we list the .S not the resulting .o in files? Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E732DE85-529F-45B8-A875-FAB5C025CEA1>