Date: Sat, 19 Sep 2020 23:58:11 +0000 From: Rick Macklem <rmacklem@uoguelph.ca> To: Kyle Evans <kevans@freebsd.org> Cc: Alan Somers <asomers@freebsd.org>, Konstantin Belousov <kostikbel@gmail.com>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r365643 - head/bin/cp Message-ID: <YTBPR01MB39666CFFA41BFFA0B5335F88DD3C0@YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM> In-Reply-To: <CACNAnaGeS-uBJfRoniWVizMFpNc3xvwyDfaXv0WSKL4uWBuwvA@mail.gmail.com> References: <202009112049.08BKnavL032212@repo.freebsd.org> <20200911214327.GY94807@kib.kiev.ua> <YTBPR01MB3966E158BCA0C56C5EE64CA8DD240@YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM> <CAOtMX2hLLE1c=qbhSFnoRk2SfAg9sOk0PZtiyvNZ_u39YwGKmA@mail.gmail.com> <YTBPR01MB3966A515F676EB5B938AC007DD3C0@YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM>, <CACNAnaGeS-uBJfRoniWVizMFpNc3xvwyDfaXv0WSKL4uWBuwvA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Kyle Evans wrote:=0A=
[stuff snipped]=0A=
>Testing on Debian I seem to get back an EINVAL, but I think it's maybe=0A=
>a little surprising:=0A=
>=0A=
> EXDEV The files referred to by file_in and file_out are=0A=
> not on the same mounted filesystem.=0A=
Well, as Alan noted, Linux is not a standard and they've also changed the=
=0A=
semantics of copy_file_range(2) significantly since it was introduced.=0A=
Here's what the most current man page I have says:=0A=
EXDEV The files referred to by fd_in and fd_out are not on the same=
=0A=
mounted filesystem (pre Linux 5.3).=0A=
Note the change as of Linux5.3. They also initially did not allow it to wor=
k=0A=
across multiple file systems and then changed to allowing that.=0A=
--> All I could do was try and be compatible with the most up to date=0A=
man page I had, which does also state:=0A=
EINVAL Either fd_in or fd_out is not a regular file.=0A=
=0A=
So, I guess the surprising part for me is how quickly (and wthout concerns=
=0A=
w.r.t. backwards compatibility) the Linux kernel folk change things.;-)=0A=
=0A=
All part of the fun, rick=0A=
=0A=
Thanks,=0A=
=0A=
Kyle Evans=0A=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YTBPR01MB39666CFFA41BFFA0B5335F88DD3C0>