Date: Sun, 16 Oct 2005 21:50:32 +0300 From: Panagiotis Astithas <past@ebs.gr> To: "Mikhail T." <mi@aldan.algebra.com> Cc: java@freebsd.org, phantom@freebsd.org Subject: Re: JDK should use system's zlib Message-ID: <4352A0F8.9030902@ebs.gr> In-Reply-To: <200510161507.j9GF7ACB003843@blue.virtual-estates.net> References: <200510161507.j9GF7ACB003843@blue.virtual-estates.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Mikhail T. wrote: > Hello! > > The system's zlib is much newer and better tested on our various > platforms. > > JDKs should use it instead of building their own. Attached is the > patch for ready to be dropped into jdk15/files. > > Just to be sure, a wrong header file is not picked up somewhere > else in the tree, the little diff below prevents the bundled zlib-1.1.3 > from even being extracted: > > Index: Makefile > =================================================================== > RCS file: /home/pcvs/ports/java/jdk15/Makefile,v > retrieving revision 1.94 > diff -U2 -r1.94 Makefile > --- Makefile 13 Oct 2005 15:19:18 -0000 1.94 > +++ Makefile 16 Oct 2005 15:04:57 -0000 > @@ -307,2 +307,4 @@ > > .include <bsd.port.post.mk> > + > +EXTRACT_AFTER_ARGS+= -x '*/zlib-*/*' > > > Please, test... Something like this should also be done to use the > already installed libjpeg. Yours, Seems to be working fine in my testing so far. As a side-effect it has shaved 52KB off the libzip.so binary and a total of 4MB on a debug installation. On a side note: does EXTRACT_AFTER_ARGS really have to go to the end of the Makefile? Cheers, Panagiotis
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4352A0F8.9030902>