Date: Wed, 25 Dec 2024 16:14:19 +0100 From: Mohammad Noureldin <mohammad@thelightbird.com> To: Tomoaki AOKI <junchoon@dec.sakura.ne.jp> Cc: Joseph Mingrone <jrm@freebsd.org>, hackers@freebsd.org, scottl@freebsd.org, Ed Maste <emaste@freebsd.org> Subject: Re: USB4/TBT3 support Message-ID: <CAAQ96DwGfM2zL26GZaQz=MBv5PDkfpo0RzQD63hmn7vS20zwmA@mail.gmail.com> In-Reply-To: <20241223032523.d9700186b36c60f3ed9b5995@dec.sakura.ne.jp> References: <864j8lmaub.fsf@phe.ftfl.ca> <CAAQ96DyTnbkj4M2cVrHgvcTtPhvz-mKs%2B8bn_NuAqrkkYW5goQ@mail.gmail.com> <20241223032523.d9700186b36c60f3ed9b5995@dec.sakura.ne.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000aa32bf062a19af56 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Tomoaki, 1st of all, thanks a lot for sharing your notes and insights helping to enrich the discussion On Sun, Dec 22, 2024 at 7:25=E2=80=AFPM Tomoaki AOKI <junchoon@dec.sakura.n= e.jp> wrote: > On Fri, 20 Dec 2024 17:04:20 +0100 > Mohammad Noureldin <mohammad@thelightbird.com> wrote: > <snip> > > Hi. > Thanks for the pointer. > > Some notes: > *hselasky@ (RIP, Hans...) suffered from the lack of official and open > hardware specs for implementing his driver. > > *hselasky@ wasn't going to implement TB3's security features > as it seemed NOT to be sufficient for actual security in spec itself. > > *I have Titan Ridge TB3 controller (falles back to Intel Cannon Lake > USB 3.1 controller when TB3 device is not connected) in my ThinkPad > P52, but hselasky@'s last driver didn't work for it, as his driver > only supports older generation of controller chipset (with the lack > of information). > > *P52 recognizes TB3-only device (Samsung X5 external SSD I've > purchased for test) as internal PCIe drive if it was attached > before powerint on the computer, but hot deplugging causes panic, > with and without hselasky@'s driver installed. > > *My related info are in Bug 237666 [1]. > > [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D237666 Believe or not, I was in touch with HPS (may he RIP) over this specific PR given my general interest in USB and I've even purchased 3 2nd hand machines to help testing and get to the root cause: - Dell Precision Tower 5810 -# Which proved not to be useful for this case - Lenovo ThinkPad P52s - Lenovo ThinkPad T480 -# Because Bjoern Zeeb (bz@) could reproduce the original reported issue on this machine and he wrote down some notes about his findings in [1] But that EuroBSDCon of year 2023 when I was planning to bring one or both of these Lenovos with me to tinker on them with HPS, I cam to know that he passed away before the EuroBSDCon's starting date ... RIP HPS. I've added the *"Problem Reports to be Possibly Revisited"* section [2] because in addition to [3] I've noticed other similar PR(s) where we can revisit after a working driver is in place to either: - Indicate that now this works - Or, it still not working, we won't support it, and write this down in a clear way for end users Also to hopefully make the scope more clear, I've added a Scope sub-section [4] > > -- > Tomoaki AOKI <junchoon@dec.sakura.ne.jp> > Thanks again Tomoaki and happy holidays =F0=9F=91=8A [1] https://wiki.freebsd.org/BjoernZeeb/USB [2] https://wiki.freebsd.org/MohammadNoureldin/FreeBSDUSB4TBT3Support#Problem_R= eports_To_Be_Possibly_Revisited [3] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D237666 [4] https://wiki.freebsd.org/MohammadNoureldin/FreeBSDUSB4TBT3Support#Scope --=20 Thanks - Mohammad Noureldin -- "Life is like riding a bicycle. To keep your balance you must keep moving" - Albert Einstein --000000000000aa32bf062a19af56 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr">Hi Tomoaki,</div><div><b= r></div><div>1st of all, thanks a lot for sharing your notes and insights h= elping to enrich the discussion</div><br><div class=3D"gmail_quote"><div di= r=3D"ltr" class=3D"gmail_attr">On Sun, Dec 22, 2024 at 7:25=E2=80=AFPM Tomo= aki AOKI <<a href=3D"mailto:junchoon@dec.sakura.ne.jp" target=3D"_blank"= >junchoon@dec.sakura.ne.jp</a>> wrote:<br></div><blockquote class=3D"gma= il_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,2= 04,204);padding-left:1ex">On Fri, 20 Dec 2024 17:04:20 +0100<br> Mohammad Noureldin <<a href=3D"mailto:mohammad@thelightbird.com" target= =3D"_blank">mohammad@thelightbird.com</a>> wrote:<br></blockquote><div><= br></div><div><snip></div><div>=C2=A0</div><blockquote class=3D"gmail= _quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204= ,204);padding-left:1ex"> <br> Hi.<br> Thanks for the pointer.<br> <br> Some notes:<br> =C2=A0 *hselasky@ (RIP, Hans...) suffered from the lack of official and ope= n<br> =C2=A0 =C2=A0hardware specs for implementing his driver.<br> <br> =C2=A0 *hselasky@ wasn't going to implement TB3's security features= <br> =C2=A0 =C2=A0as it seemed NOT to be sufficient for actual security in spec = itself.<br> <br> =C2=A0 *I have Titan Ridge TB3 controller (falles back to Intel Cannon Lake= <br> =C2=A0 =C2=A0USB 3.1 controller when TB3 device is not connected) in my Thi= nkPad<br> =C2=A0 =C2=A0P52, but hselasky@'s last driver didn't work for it, a= s his driver<br> =C2=A0 =C2=A0only supports older generation of controller chipset (with the= lack<br> =C2=A0 =C2=A0of information).<br> <br> =C2=A0 *P52 recognizes TB3-only device (Samsung X5 external SSD I've<br= > =C2=A0 =C2=A0purchased for test) as internal PCIe drive if it was attached<= br> =C2=A0 =C2=A0before powerint on the computer, but hot deplugging causes pan= ic,<br> =C2=A0 =C2=A0with and without hselasky@'s driver installed.<br> <br> =C2=A0 *My related info are in Bug 237666 [1].<br> <br> [1] <a href=3D"https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D237666" = rel=3D"noreferrer" target=3D"_blank">https://bugs.freebsd.org/bugzilla/show= _bug.cgi?id=3D237666</a></blockquote><div><br></div><div>Believe or not, I = was in touch with HPS (may he RIP) over this specific PR given my general i= nterest in USB and I've even purchased 3 2nd hand machines to help test= ing and get to the root cause:</div><div>- Dell Precision Tower 5810</div><= div>-# Which proved not to be useful for this case</div><div>- Lenovo Think= Pad P52s</div><div>- Lenovo ThinkPad T480</div><div>-# Because=C2=A0Bjoern = Zeeb=C2=A0(bz@) could reproduce the original reported issue on this machine= and he wrote down some notes about his findings in [1]</div><div>=C2=A0</d= iv><div>But that EuroBSDCon of year 2023 when I was planning to bring one o= r both of these Lenovos with me to tinker on them with HPS, I cam to know t= hat he passed away before the EuroBSDCon's starting date ... RIP HPS.</= div><div><br></div>I've added the <b>"Problem Reports to be Possib= ly Revisited"</b> section [2] because in addition to [3] I've noti= ced other similar PR(s) where we can revisit after a working driver is in p= lace to either:</div><div class=3D"gmail_quote">- Indicate that now this wo= rks</div><div class=3D"gmail_quote">- Or, it still not working, we won'= t support it, and write this down in a clear way for end users<br><div><br>= </div><div>Also to hopefully make the scope more clear, I've added a Sc= ope sub-section [4]</div><div><br></div><blockquote class=3D"gmail_quote" s= tyle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pad= ding-left:1ex"><br> <br> -- <br> Tomoaki AOKI=C2=A0 =C2=A0 <<a href=3D"mailto:junchoon@dec.sakura.ne.jp" = target=3D"_blank">junchoon@dec.sakura.ne.jp</a>><br> </blockquote></div><div><br clear=3D"all"></div><div>Thanks again Tomoaki a= nd happy holidays=C2=A0=F0=9F=91=8A</div><div><br></div><div>[1]=C2=A0<a hr= ef=3D"https://wiki.freebsd.org/BjoernZeeb/USB" target=3D"_blank">https://wi= ki.freebsd.org/BjoernZeeb/USB</a></div><div>[2]=C2=A0<a href=3D"https://wik= i.freebsd.org/MohammadNoureldin/FreeBSDUSB4TBT3Support#Problem_Reports_To_B= e_Possibly_Revisited" target=3D"_blank">https://wiki.freebsd.org/MohammadNo= ureldin/FreeBSDUSB4TBT3Support#Problem_Reports_To_Be_Possibly_Revisited</a>= </div><div>[3]=C2=A0<a href=3D"https://bugs.freebsd.org/bugzilla/show_bug.c= gi?id=3D237666" rel=3D"noreferrer" target=3D"_blank">https://bugs.freebsd.o= rg/bugzilla/show_bug.cgi?id=3D237666</a></div><div>[4]=C2=A0<a href=3D"http= s://wiki.freebsd.org/MohammadNoureldin/FreeBSDUSB4TBT3Support#Scope">https:= //wiki.freebsd.org/MohammadNoureldin/FreeBSDUSB4TBT3Support#Scope</a></div>= <div><br></div><span class=3D"gmail_signature_prefix">-- </span><br><div di= r=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr" = style=3D"color:rgb(136,136,136)">Thanks<br>- Mohammad Noureldin<br>--<br>&q= uot;Life is like riding a bicycle. To keep your balance you must keep movin= g"<br>- Albert Einstein</div></div><div dir=3D"ltr" style=3D"color:rgb= (136,136,136)"><br></div></div></div></div> </div> --000000000000aa32bf062a19af56--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAAQ96DwGfM2zL26GZaQz=MBv5PDkfpo0RzQD63hmn7vS20zwmA>