Date: Sat, 3 Feb 2007 16:19:28 +0000 (UTC) From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/usb uhub.c Message-ID: <200702031619.l13GJTNv098101@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
imp 2007-02-03 16:19:28 UTC
FreeBSD src repository
Modified files:
sys/dev/usb uhub.c
Log:
Fix memory leak of devinfo. The leak itself was documented in
PR/108719, but there's a simpler fix: free it after it is used, and
then get rid of the redundant frees this causes. Other leaks in this
PR not yet fixed.
While I'm here, remove NetBSD/OpenBSD code and some of the portability
#defines that were getting in the way of understanding this code. The
devinfo bug was harder to spot because one needed to know that
device_set_desc_copy() was used inside of one of them (one that didn't
take an argument!).
Prefer device_printf(sc->sc_dev, "...") to printf("%s:...",
device_get_nameunit(sc->sc_dev)). This saves almost 300 bytes.
PR: 108719
Submitted by: Antoine Brodin
Revision Changes Path
1.73 +66 -122 src/sys/dev/usb/uhub.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200702031619.l13GJTNv098101>