Date: Wed, 10 Sep 2008 13:23:40 +0100 From: "Bruce M. Simpson" <bms@FreeBSD.org> To: Brooks Davis <brooks@freebsd.org> Cc: FreeBSD-Net mailing list <freebsd-net@freebsd.org> Subject: Re: Problem with IFDATA_DRIVERNAME sysctl Message-ID: <48C7BC4C.4090106@FreeBSD.org> In-Reply-To: <20080910003637.GB34060@lor.one-eyed-alien.net> References: <48C70743.1020003@incunabulum.net> <48C7112D.3070309@FreeBSD.org> <20080910003637.GB34060@lor.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Brooks Davis wrote:
>
>> --- if_mib.c.orig 2008-09-10 00:31:25.000000000 +0100
>> +++ if_mib.c 2008-09-10 00:32:15.000000000 +0100
>> @@ -90,6 +90,7 @@
>> switch(name[1]) {
>> default:
>> return ENOENT;
>> + break;
>>
>
> That's clearly a no-op since it's unreachable.
>
>
>> case IFDATA_GENERAL:
>> bzero(&ifmd, sizeof(ifmd));
>> @@ -136,6 +137,7 @@
>> error = SYSCTL_IN(req, ifp->if_linkmib, ifp->if_linkmiblen);
>> if (error)
>> return error;
>> + break;
>>
>
> This looks OK, but I haven't checked the context.
>
It looks like an unintentional fall-through to case IFDATA_DRIVERNAME,
so I'll commit that part.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?48C7BC4C.4090106>