Date: Mon, 05 Jul 2004 08:29:07 +0900 From: Rob <stopspam@users.sourceforge.net> To: freebsd-stable@freebsd.org, freebsd-questions@freebsd.org Subject: Re: -STABLE build appears broken after ipfilter 3.4.35 MFC Message-ID: <40E892C3.7060704@users.sourceforge.net> In-Reply-To: <200407041136.54692.kstewart@owt.com> References: <200407041407.i64E7lUO028658@bunrab.catwhisker.org> <20040704165557.GC14695@ip.net.ua> <200407041136.54692.kstewart@owt.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Kent Stewart wrote: > On Sunday 04 July 2004 09:55 am, Ruslan Ermilov wrote: > >>On Sun, Jul 04, 2004 at 07:07:47AM -0700, David Wolfskill wrote: >> >>>[I sent a copy of this information under separate cover to Darren >>>Reed a little while ago. dhw] > > > Darren's 1741 UTC to ip_fil.h fix lets it build on my test system. I cvsup'ed against cvsup.freebsd.org. The kernel build still fails: [...] /usr/src/sys/modules/ipfilter/../../contrib/ipfilter/netinet/ip_fil.c: In function `send_ip': /usr/src/sys/modules/ipfilter/../../contrib/ipfilter/netinet/ip_fil.c:1325: void value not ignored as it ought to be *** Error code 1 ---- Reason for this seems: In contrib/ipfilter/netinet/ip_fil.c:1325, there is if (fr_makefrip(hlen, ip, &frn) == 0) and in contrib/ipfilter/netinet/ip_fil.h:633, it has extern void fr_makefrip __P((int, ip_t *, fr_info_t *)); A void-function cannot be tested against a return value! Rob
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?40E892C3.7060704>