Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 17 Dec 2012 06:01:57 +0000 (UTC)
From:      Pyun YongHyeon <yongari@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r244341 - head/sys/dev/ale
Message-ID:  <201212170601.qBH61vF2028979@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: yongari
Date: Mon Dec 17 06:01:57 2012
New Revision: 244341
URL: http://svnweb.freebsd.org/changeset/base/244341

Log:
  Make sure to stop both TX and RX MACs in ale_stop_mac(). Previously
  it used to stop TX MAC only such that MAC reconfiguration after
  getting a link didn't work as expected.
  
  PR:	kern/173652

Modified:
  head/sys/dev/ale/if_ale.c

Modified: head/sys/dev/ale/if_ale.c
==============================================================================
--- head/sys/dev/ale/if_ale.c	Mon Dec 17 05:31:42 2012	(r244340)
+++ head/sys/dev/ale/if_ale.c	Mon Dec 17 06:01:57 2012	(r244341)
@@ -2932,7 +2932,7 @@ ale_stop_mac(struct ale_softc *sc)
 
 	reg = CSR_READ_4(sc, ALE_MAC_CFG);
 	if ((reg & (MAC_CFG_TX_ENB | MAC_CFG_RX_ENB)) != 0) {
-		reg &= ~MAC_CFG_TX_ENB | MAC_CFG_RX_ENB;
+		reg &= ~(MAC_CFG_TX_ENB | MAC_CFG_RX_ENB);
 		CSR_WRITE_4(sc, ALE_MAC_CFG, reg);
 	}
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201212170601.qBH61vF2028979>