Date: Fri, 3 Nov 2006 09:06:02 +0200 From: Vasil Dimov <vd@FreeBSD.org> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/mpatrol Makefile ports/devel/mpatrol/files patch-..::..::src::mptrace.c Message-ID: <20061103070602.GA65515@qlovarnika.bg.datamax> In-Reply-To: <454AE6B2.70702@FreeBSD.org> References: <200611030351.kA33peWQ061783@repoman.freebsd.org> <20061103061317.GB64699@qlovarnika.bg.datamax> <454ADF4A.5080201@FreeBSD.org> <20061103064819.GA64957@qlovarnika.bg.datamax> <454AE6B2.70702@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--a8Wt8u1KmwUX3Y2C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 02, 2006 at 10:50:26PM -0800, Maxim Sobolev wrote: > Vasil Dimov wrote: > >On Thu, Nov 02, 2006 at 10:18:50PM -0800, Maxim Sobolev wrote: > >>Vasil Dimov wrote: > >>>On Fri, Nov 03, 2006 at 03:51:40AM +0000, Maxim Sobolev wrote: > >>>>sobomax 2006-11-03 03:51:40 UTC > >>>[...] > >>>> Added files: > >>>> devel/mpatrol/files patch-..::..::src::mptrace.c=20 > >>>Aargh :-/ > >>>I thought we were supposed to use Tools/scripts/splitpatch.pl for new > >>>patches. > >>Why so? We have Tools/scripts/patchtool.py for the few years now. > > > >The note I made was about the convention, not the exact tool used. You > >should read: > > > >"I thought we were supposed to use the convention used by > >Tools/scripts/splitpatch.pl for new patches." >=20 > Who those "we" are and why exactly they should use that "convention"? Is= =20 > it official or what? Those "we" are the ones creating new patches for FreeBSD ports and placing them in files/ subdirectories. _They_ should use that convention because it is better to have some convention than no convention at all. Please read http://www.freebsd.org/doc/en/books/porters-handbook/slow-patch.html especially: "Each patch you wish to apply should be saved into a file named patch-* where * indicates the pathname of the file that is patched, such as patch-Imakefile or patch-src-config.h =2E.. Please only use characters [-+._a-zA-Z0-9] for naming your patches." I dunno what do you mean by "official" and if you consider the "Porters Handbook" being "official". Anyway you can name your patches patch-@}>-->---ILoveYouMary-src_file.c if you like but you will raise usless discussions like the current one. --=20 Vasil Dimov gro.DSBeerF@dv % Be braver -- you can't cross a chasm in two small jumps. --a8Wt8u1KmwUX3Y2C Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- iD8DBQFFSupaFw6SP/bBpCARAjrnAKDFjmey3z0XuV/y2Tp4ewnYZUGaUACdH4mX 5orXh0yoccQsifLLpMV7Edg= =H0jq -----END PGP SIGNATURE----- --a8Wt8u1KmwUX3Y2C--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061103070602.GA65515>