Date: Sat, 14 Jan 2006 13:19:55 -0800 From: Doug Barton <dougb@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: cvs-src@freebsd.org, Gleb Smirnoff <glebius@freebsd.org>, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/bge if_bge.c src/sys/dev/em if_em.c src/sys/dev/ixgb if_ixgb.c src/sys/dev/nge if_nge.c src/sys/dev/re if_re.c src/sys/dev/txp if_txp.c src/sys/dev/vge if_vge.c src/sys/net if_vlan.c if_vlan_var.h src/sys/net80211 ... Message-ID: <43C96AFB.9070400@FreeBSD.org> In-Reply-To: <200601141543.27356.jhb@freebsd.org> References: <200601131151.k0DBpDhC039336@repoman.freebsd.org> <43C8692A.9040301@FreeBSD.org> <200601141543.27356.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote:
> I'm not sure that's quite fair. :) What happened is that his original patch
> did work fine (and has been in HEAD for a while), but it changed the API, so
> he did a quick fixup to restore the API in RELENG_6 and missed one file
> during that subsequent update.
I should have been more clear. I wasn't asking if the change had been
tested, I followed the thread where it was discussed for HEAD. What I should
have asked is, "Did you test the change in RELENG_6 by at minimum building
world and kernel before you committed?" Doing so would have caught the
missed file, and avoided breakage in a -stable branch.
Doug
--
This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?43C96AFB.9070400>