Date: Sun, 27 Apr 2014 15:34:45 GMT From: "A.J. van Werven" <freebsd@skysmurf.nl> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/189050: [PATCH] games/oneko fails to build with Clang Message-ID: <201404271534.s3RFYjEn097908@cgiserv.freebsd.org> Resent-Message-ID: <201404271540.s3RFe2LM090046@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 189050
>Category: ports
>Synopsis: [PATCH] games/oneko fails to build with Clang
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Apr 27 15:40:02 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: A.J. van Werven
>Release: 9.1-RELEASE-p3
>Organization:
>Environment:
>Description:
The games/oneko port fails to build on FreeBSD 9.1-RELEASE-p3/amd64, if Clang is used as the compiler.
The function NekoChangeVisibility() in event.c does not have a return type specified. It is therefore assumed to return int, while it doesn't actually return anything. Explicitly specifying this function to be of type void fixes the problem.
>How-To-Repeat:
# portmaster games/oneko
(On a system that uses Clang, I didn't try with GCC.)
>Fix:
Apply the supplied patch to event.c.
Please note: the port's Makefile explicitly specifies a do-patch target, so the Makefile will probably have to be updated as well, in order to make sure the patch actually gets applied.
Patch attached with submission follows:
--- event.c.bak 2014-04-27 16:54:53.000000000 +0200
+++ event.c 2014-04-27 16:55:20.000000000 +0200
@@ -230,6 +230,7 @@
}
#endif /* SENDER */
+void
NekoChangeVisibility(window)
Window window;
{
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201404271534.s3RFYjEn097908>