Date: Fri, 21 Dec 2012 18:39:56 -1000 (TAHT) From: Gerald Pfeifer <gerald@pfeifer.com> To: Maho NAKATA <chat95@mac.com>, office@FreeBSD.org Subject: Re: Eliminating use of _GCC_BUILD_DEPENDS from openoffice-3-devel Message-ID: <alpine.LNX.2.00.1212211836410.2358@tuna.site> In-Reply-To: <20121108.175634.255451043250472753.chat95@mac.com> References: <alpine.LNX.2.00.1211031717260.2266@tuna.site> <20121105.155038.872338780898971147.maho@FreeBSD.org> <alpine.LNX.2.00.1211060128070.2266@tuna.site> <20121108.175634.255451043250472753.chat95@mac.com>
index | next in thread | previous in thread | raw e-mail
On Thu, 8 Nov 2012, Maho NAKATA wrote:
>> To verify, can you run ldd on the core dumping binary in both
>> cases, the one that fails (core dump) and the one that does not
>> dump? And see how that output differs?
>
> On FreeBSD 8.2-RELEASE, amd64
> Non working version:
> $ ldd /work/tinderbox-ligeti8amd64/portstrees/FreeBSD/ports/editors/openoffice-3-devel/work/ooo/main/solver/350/unxfbsdx.pro/bin/autodoc
> /work/tinderbox-ligeti8amd64/portstrees/FreeBSD/ports/editors/openoffice-3-devel/work/ooo/main/solver/350/unxfbsdx.pro/bin/autodoc:
> libstlport_gcc.so => not found (0x0)
> libstdc++.so.6 => /usr/lib/libstdc++.so.6 (0x8008f0000)
> libm.so.5 => /lib/libm.so.5 (0x800b00000)
> libgcc_s.so.1 => /lib/libgcc_s.so.1 (0x800c20000)
> libthr.so.3 => /lib/libthr.so.3 (0x800d2e000)
> libc.so.7 => /lib/libc.so.7 (0x800e47000)
>
> working version:
> $ ldd /work/tinderbox-ligeti8amd64/portstrees/FreeBSD/ports/editors/openoffice-3-devel/work/ooo/main/solver/350/unxfbsdx.pro/bin/autodoc
> /work/tinderbox-ligeti8amd64/portstrees/FreeBSD/ports/editors/openoffice-3-devel/work/ooo/main/solver/350/unxfbsdx.pro/bin/autodoc:
> libstlport_gcc.so => not found (0x0)
> libstdc++.so.6 => /usr/local/lib/gcc46/libstdc++.so.6 (0x8008f0000)
> libm.so.5 => /lib/libm.so.5 (0x800bf3000)
> libgcc_s.so.1 => /usr/local/lib/gcc46/libgcc_s.so.1 (0x800d13000)
> libthr.so.3 => /lib/libthr.so.3 (0x800f28000)
> libc.so.7 => /lib/libc.so.7 (0x801041000)
>
> Yeah, it is expected ;-)
So, it looks like OpenOffice is not using CXXFLAGS and/or LDFLAGS
properly.
Is there any chance you can look into this or report this upstream,
so that it's fixed? We do set things correctly in Mk/bsd.gcc.mk, I
believe, so it's something in the port (or upstream) I'm afraid.
Gerald
PS: For now I'd like to apply the change I made to the -devel port
to the main port as well; okay?
>From gerald@pfeifer.com Sat Oct 13 11:27:43 2012
From: Gerald Pfeifer <gerald@pfeifer.com>
To: office@FreeBSD.org
Date: Sat, 13 Oct 2012 23:27:41 +0200 (CEST)
Subject: Eliminating use of _GCC_BUILD_DEPENDS from openoffice-3-devel
_GCC_BUILD_DEPENDS never was meant to be used outside of Mk/bsd.gcc.mk,
and the settings of CFLAGS et al really should be sufficient.
Apparently it was felt that was not the case, or something is not
working as it should, I don't think I was asked about before this
was put in.
In any case, can we go for this patch which eliminates _GCC_BUILD_DEPENDS
in favor of a new _GCC_RUNTIME? That is a stop gap, but at least
an official one and easier than manually constructing the library
path.
Okay to apply the patch below to openoffice-3-devel and, a bit
later, openoffice-3?
Thanks,
Gerald
Index: Makefile
===================================================================
--- Makefile (revision 305792)
+++ Makefile (working copy)
@@ -1,9 +1,5 @@
-# New ports collection makefile for: Apache OpenOffice
-# Date created: 28 February 2002
-# Whom: Martin Blapp
-#
+# Created by: Martin Blapp
# $FreeBSD$
-#
PORTNAME= apache-openoffice
PORTVERSION= 3.4.${SVNREVISION}
@@ -252,8 +248,8 @@
post-patch:
.if defined (USE_GCC)
- @${REINPLACE_CMD} -e "s+%%RPATH%%+-Wl,-rpath=${LOCALBASE}/lib/${_GCC_BUILD_DEPENDS}+" ${WRKSRC}/solenv/inc/unxfbsd.mk
- @${REINPLACE_CMD} -e "s+%%RPATH%%+-Wl,-rpath=${LOCALBASE}/lib/${_GCC_BUILD_DEPENDS}+" ${WRKSRC}/solenv/gbuild/platform/freebsd.mk
+ @${REINPLACE_CMD} -e "s+%%RPATH%%+-Wl,-rpath=${_GCC_RUNTIME}+" ${WRKSRC}/solenv/inc/unxfbsd.mk
+ @${REINPLACE_CMD} -e "s+%%RPATH%%+-Wl,-rpath=${_GCC_RUNTIME}+" ${WRKSRC}/solenv/gbuild/platform/freebsd.mk
.else
@${REINPLACE_CMD} -e "s+%%RPATH%%++" ${WRKSRC}/solenv/inc/unxfbsd.mk
@${REINPLACE_CMD} -e "s+%%RPATH%%++" ${WRKSRC}/solenv/gbuild/platform/freebsd.mk
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LNX.2.00.1212211836410.2358>