Date: Tue, 4 Apr 2017 14:39:33 +0000 From: "glebius (Gleb Smirnoff)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE Message-ID: <adfeeb8332a73be57c1a8e306f6862e5@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-zs5j6sjj2bwywywa3p22-req@FreeBSD.org> References: <differential-rev-PHID-DREV-zs5j6sjj2bwywywa3p22-req@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
glebius requested changes to this revision. glebius added a comment. This revision now requires changes to proceed. I got few minor comments. INLINE COMMENTS > ng_pppoe.c:1135 > + /* Generate a packet of that type. */ > + MGETHDR(m, M_NOWAIT, MT_DATA); > + if (m == NULL) This is deprecated macro. Please use m_gethdr(M_NOWAIT, MT_DATA); > ng_pppoe.c:1144 > + > + m->m_pkthdr.rcvif = NULL; > + m->m_pkthdr.len = m->m_len = sizeof(*wh); This is already done by the allocator. Not needed. > ng_pppoe.c:1145 > + m->m_pkthdr.rcvif = NULL; > + m->m_pkthdr.len = m->m_len = sizeof(*wh); > + wh = mtod(m, struct pppoe_full_hdr *); Looks like m_pkthdr.len is never read before it is overwritten later in L1167. > ng_pppoe.c:1180 > + /* Generate a packet of that type. */ > + MGETHDR(m, M_NOWAIT, MT_DATA); > + if (m == NULL) Same comments on this block as on SEND_HURL. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D9270 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: ale, #manpages, wblock, #network, julian, mav, adrian, glebius Cc: glebius, wblock, mav, poolroom_gmail.com, mandree, imp, freebsd-net-listhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?adfeeb8332a73be57c1a8e306f6862e5>