Date: Mon, 3 Sep 2012 17:40:50 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Pedro Giffuni <pfg@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240060 - in head: include/rpc sys/rpc Message-ID: <20120903144050.GN33100@deviant.kiev.zoral.com.ua> In-Reply-To: <1346681599.92069.YahooMailClassic@web113502.mail.gq1.yahoo.com> References: <20120903073133.GB33100@deviant.kiev.zoral.com.ua> <1346681599.92069.YahooMailClassic@web113502.mail.gq1.yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Mon, Sep 03, 2012 at 07:13:19AM -0700, Pedro Giffuni wrote: > Hello, > > Sorry for the brevity but I can inly anser on a mobile device > right now ... > > --- Lun 3/9/12, Konstantin Belousov <kostikbel@gmail.com> ha scritto: > > > Da: Konstantin Belousov <kostikbel@gmail.com> > > Oggetto: Re: svn commit: r240060 - in head: include/rpc sys/rpc > > A: "Pedro F. Giffuni" <pfg@freebsd.org> > > Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org > > Data: Luned? 3 settembre 2012, 02:31 > > On Sun, Sep 02, 2012 at 09:04:40PM > > +0000, Pedro F. Giffuni wrote: > > > Author: pfg > > > Date: Sun Sep 2 21:04:40 2012 > > > New Revision: 240060 > > > URL: http://svn.freebsd.org/changeset/base/240060 > > > > > > Log: > > >Fix RPC headers for C++ > > > > > >C++ mangling will cause trouble with > > variables like __rpc_xdr > > >in xdr.h so rename this to XDR. > > Which troubles ? > > > > PR 137443 From the PR, I fail to see what is the problem in our headers, and why the issue is not in some third-party C++ code. It is definitely has nothing to do with C++ name mangling. > > > Although not very useful due to many other namespace > > pollution problems > > in the rpc headers, __rpc_xdr is in the > > implementation-reserved namespace, > > while XDR is not. > > > > The forced reference here is {Open}Solaris: > > http://src.illumos.org/source/xref/illumos-gate/usr/src/uts/common/rpc/xdr.h > > OpenGrok found no reference to __rpc_xdr > in OpenSolaris/illumos. I see, Solaris does typedef struct XDR { ... } XDR; and we now use the same trick. So my objections, if any, were against the commit message and not the actual code change then. Thanks. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAlBEwXIACgkQC3+MBN1Mb4j61gCgiweJgcQqiX2TBPu+ZTFXHF6b K00AoNQWrqMSIQWySdAC2Vbb0x1LDuuv =xCph -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120903144050.GN33100>