Date: Sun, 14 Sep 2025 08:14:22 GMT From: Konstantin Belousov <kib@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: a85525a5c8b2 - main - pdgetpid(2): switch back returning EBADF for non-procdesc fd Message-ID: <202509140814.58E8EM8L013264@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=a85525a5c8b28f1516d49e5d6ae5842873c24643 commit a85525a5c8b28f1516d49e5d6ae5842873c24643 Author: Konstantin Belousov <kib@FreeBSD.org> AuthorDate: 2025-09-13 19:23:27 +0000 Commit: Konstantin Belousov <kib@FreeBSD.org> CommitDate: 2025-09-14 08:11:03 +0000 pdgetpid(2): switch back returning EBADF for non-procdesc fd This partially reverts fd9e09cb2ab0, since apparently QT depends on this specific error code. It seems that it applies pdgetpid() to random fds and filters non-procdescs by checking errno for EBADF. Reported by: arrowd, Kenneth Raplee <kenrap@kennethraplee.com> Sponsored by: The FreeBSD Foundation MFC after: 1 week --- sys/kern/sys_procdesc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/sys_procdesc.c b/sys/kern/sys_procdesc.c index 54b03fc82c90..acaf1241cb2e 100644 --- a/sys/kern/sys_procdesc.c +++ b/sys/kern/sys_procdesc.c @@ -175,7 +175,7 @@ kern_pdgetpid(struct thread *td, int fd, const cap_rights_t *rightsp, if (error) return (error); if (fp->f_type != DTYPE_PROCDESC) { - error = EINVAL; + error = EBADF; goto out; } *pidp = procdesc_pid(fp);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202509140814.58E8EM8L013264>