Date: Sat, 19 Apr 2003 10:49:39 -0700 From: bmah@FreeBSD.org (Bruce A. Mah) To: Hiroki Sato <hrs@eos.ocn.ne.jp> Cc: doc@FreeBSD.org Subject: Re: suggestion for adding a l10n-capable doc-format navi Message-ID: <200304191749.h3JHndxV053505@bmah.dyndns.org> In-Reply-To: <20030420.020436.102903006.hrs@eos.ocn.ne.jp> References: <20030414.053436.95910003.hrs@eos.ocn.ne.jp> <20030419.204208.38720452.hrs@eos.ocn.ne.jp> <200304191540.h3JFeSxV052609@bmah.dyndns.org> <20030420.020436.102903006.hrs@eos.ocn.ne.jp>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
If memory serves me right, Hiroki Sato wrote:
> bmah> Random thought: I wonder if it'd have been better to leaving it defaul
> t
> bmah> to "WITH_DOCFORMAT_NAVI_LINK?=NO" and then explicitly setting
> bmah> "WITH_DOCFORMAT_NAVI_LINK=YES" in the Web site build, the release build
> bmah> doc.1 target, etc. The case I am thinking of is that if someone builds
> bmah> an html version only (the default), they'll get a dangling link to a
> bmah> non-existant (or stale) html-split version.
>
> Yes, you have got a point. I made another patch that makes the link
> be generated only when ${FORMATS} includes both of "html" and "html-split,"
> and "WITH_DOCFORMAT_NAVI_LINK=YES."
OK. I *think* this is better. This will make it more conservative
about adding the navi-link, but it will give it to us whenever we know
that we have both versions available. (Plus we can still override it
if for some reason we need to do this.)
> In the current doc.docbook.mk
> WITH_FOO=NO does not work properly, but the patch fixes it, too.
Hmmm...it looks to me like with the other (already existing) variables,
we don't care what their value is. The convention here seems to be
that if WITH_FOO is defined, we want FOO regardless of what the value
was. Does anyone know if anything depends on the old behavior?
Thanks!
Bruce.
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
Comment: Exmh version 2.5+ 20020506
iD8DBQE+oYwz2MoxcVugUsMRAlI7AKCenaIWMfjInriKoqn4QEBB41K3JACcD5uo
K1y4oRw1QfbQOOXyIBS0Z7c=
=xSnw
-----END PGP SIGNATURE-----
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200304191749.h3JHndxV053505>