Date: Sat, 15 Nov 2014 21:26:08 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: Alfred Perlstein <alfred@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Garrett Cooper <ngie@FreeBSD.org> Subject: Re: svn commit: r274573 - head/contrib/netbsd-tests/lib/libpthread Message-ID: <DB00B2E1-F43A-486C-81EF-A010901E5602@gmail.com> In-Reply-To: <54683508.3030104@freebsd.org> References: <201411160508.sAG58JdG055637@svn.freebsd.org> <546833FE.9060904@freebsd.org> <45B1482F-352E-4874-8A89-1EC225A32E93@gmail.com> <54683508.3030104@freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Nov 15, 2014, at 21:24, Alfred Perlstein <alfred@freebsd.org> wrote: > On 11/15/14, 9:22 PM, Garrett Cooper wrote: >> On Nov 15, 2014, at 21:19, Alfred Perlstein <alfred@freebsd.org> wrote: >> >>> This looks easy enough to fix under _thr_find_thread() in libthread. >>> >>> Any interest in fixing it? >> Yes, if it’s POSIXly correct and doesn’t break everything else. >> >>> Might be worth hacking _thr_find_thread() to take an ERRNO to return based on NULL until we chase down all the paths into it just in case EINVAL is a valid ptr. >> K. Thanks for the hint! >> >>> Also, just wondering what happens on other platforms, does it elicit a crash? Ie. is NULL a safe value to pass in on other platforms? >> I wish I knew what happened on !x86 platforms… I honestly don’t have access to ARM/MIPS/PowerPC, so I can’t say :/. >> >> Thanks! > > Oh, I meant Linux and Solaris, or even other BSD. Ah, good question. pho@ ran some of the tests in contrib/netbsd-tests on Linux/OSX before to do a side-by-side comparison, but I haven’t setup the necessary environment to do that testing [yet]. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUaDVwAAoJEMZr5QU6S73e+V0H/0e+fH3FN4BfXneSMSd57va3 bw33x/Mp7LfsCBtRuTzXdO3zdkNxWFgih5N62TM8VhAzkvzHoVXg7dl+/BZrVkwL eDROZTikq+1T1iTmJTkm4piYjoJAAU6pAENF2+XFGocEgeqhaa3SDv/Pyks/sGSw vOSV1EeX0eeM0F5vfw6NRe58tSi8aeV5kTu/fLEMJ6+afH+WJ/k/dfGVt08HXqUJ mm++jTSbciBXBmSvLiyfAV5M9zr1rbFQhbATYIQoLKhq2xM2Z5yOMGosLSkrmdty rX/UxzEXs7LvYKzvGwO3u99VEYo52wGvGIy5fC8zfUCPu8nNrD38a50rqfsB8Sw= =DJfS -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DB00B2E1-F43A-486C-81EF-A010901E5602>