Date: Sat, 26 Feb 2011 01:34:12 +0300 From: Chagin Dmitry <dchagin@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r219042 - in head/sys: kern sys Message-ID: <20110225223412.GA7884@dchagin.static.corbina.ru> In-Reply-To: <201102251721.28461.jhb@freebsd.org> References: <201102252205.p1PM5Xlr013873@svn.freebsd.org> <201102251721.28461.jhb@freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Fri, Feb 25, 2011 at 05:21:28PM -0500, John Baldwin wrote: > On Friday, February 25, 2011 5:05:33 pm Dmitry Chagin wrote: > > Author: dchagin > > Date: Fri Feb 25 22:05:33 2011 > > New Revision: 219042 > > URL: http://svn.freebsd.org/changeset/base/219042 > > > > Log: > > Introduce preliminary support of the show description of the ABI of > > traced process by adding two new events which records value of process > > sv_flags to the trace file at process creation/execing/exiting time. > > > > MFC after: 1 Month. > > Hmm, I don't find ktrace_submitrequest_ne() an intuitive name (took a bit > to figure out 'not-entered', and it doesn't map well between getrequest() > (where it means 'already-entered') and submitrequest ('don't exit')). > > I would rather only have submitrequest() and getrequest() and push the > ktrace_enter() and ktrace_exit() into all the callers. > thnx for the reply, I thought about it. -- Have fun! chd [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) iEYEARECAAYFAk1oLmMACgkQ0t2Tb3OO/O19zwCfTA5pVrpGc8jW2MvajwvDp/TV kXAAnAj4OIESnq8tOnAuiKTlo5otUvVQ =bx96 -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110225223412.GA7884>