Date: Sun, 23 Jan 2022 08:41:30 -0800 From: Gleb Smirnoff <glebius@freebsd.org> To: Wojciech Macek <wma@semihalf.com> Cc: Kristof Provost <kp@freebsd.org>, Wojciech Macek <wma@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 9ce46cbc95d7 - main - ip_mroute: move ip_mrouter_done outside lock Message-ID: <Ye2FOvi32Xu23qIB@FreeBSD.org> In-Reply-To: <CANsEV8cmZcQKh3U8w2S37cg9heFd=icuEmF7dVwrE486OM3Yug@mail.gmail.com> References: <202201210519.20L5J1mJ029323@gitrepo.freebsd.org> <7A991003-0F24-4C8C-81FD-84F39FC78D8A@FreeBSD.org> <C25EE57B-BE5A-4BC8-AD00-C8D0D582D073@FreeBSD.org> <CANsEV8cmZcQKh3U8w2S37cg9heFd=icuEmF7dVwrE486OM3Yug@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jan 22, 2022 at 08:50:54AM +0100, Wojciech Macek wrote: W> I will prepare a fix later today. Basically, the whole "if" condition must W> be inside rwlock block to avoid race during module unload. W> Maybe adding else and rwunlock in rip_detach will suffice.... I need to try W> it out. May I ask you to post a review and add me as reviewer? Please also include a description of the problem we are fighting with. At least, a short version of it, for example "fix race between module unload and packet received". -- Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Ye2FOvi32Xu23qIB>