Date: Sat, 4 Apr 2015 12:43:21 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r281055 - head/share/mk Message-ID: <20150404104320.GB20155@ivaldir.etoilebsd.net> In-Reply-To: <BE8F2BEF-DE1D-48DB-B997-8ABDD995C48D@gmail.com> References: <201504040031.t340VedI086145@svn.freebsd.org> <BE8F2BEF-DE1D-48DB-B997-8ABDD995C48D@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Fba/0zbH8Xs+Fj9o Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 03, 2015 at 05:36:21PM -0700, Garrett Cooper wrote: > On Apr 3, 2015, at 17:31, Baptiste Daroussin <bapt@FreeBSD.org> wrote: >=20 > > Author: bapt > > Date: Sat Apr 4 00:31:40 2015 > > New Revision: 281055 > > URL: https://svnweb.freebsd.org/changeset/base/281055 > >=20 > > Log: > > Do not install scripts multiple time when using bsd.progs.mk > >=20 > > Modified: > > head/share/mk/bsd.progs.mk >=20 > I=E2=80=99m sorry I=E2=80=99ve been lax with this, but unfortunately this= doesn=E2=80=99t solve the underlying issue 100%. >=20 > 1. You forgot FILES/FILESGROUPS > 2. This doesn=E2=80=99t help cases were targets are manually overridden. > 3. Etc. >=20 > The project I was working on has reached steady state. We should be done = with the big hurdle soon-ish (another month or two). I=E2=80=99ll try to re= solve it sometime between now and then by putting all of the PROGS logic do= wn into bsd.prog.mk (where it should have been in the first place=E2=80=A6)= , because bsd.progs.mk being included recursively is a layering violation b= ug that parallel installs expose. >=20 > Thanks! Well I have hit this one while packaging base because pkg(8) yell when thin= gs are being packaged twice, so I'm fixing when I see them I plan to fix others when I'll catch them, if you prefer I can keep that on my own branch to not= make collision with your work? Best regards, Bapt --Fba/0zbH8Xs+Fj9o Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlUfwEgACgkQ8kTtMUmk6EyllgCfRPz6YWRl07WZ8f7C0bNZm9TP owIAoL63DpJa5SlNxHWJhG0l1nPWTKxD =GIU9 -----END PGP SIGNATURE----- --Fba/0zbH8Xs+Fj9o--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150404104320.GB20155>