Date: Tue, 26 Sep 2006 11:48:30 -0400 (EDT) From: "Andrew R. Reiter" <arr@watson.org> To: John-Mark Gurney <gurney_j@resnet.uoregon.edu> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet tcp_input.c Message-ID: <20060926114811.F46437@fledge.watson.org> In-Reply-To: <20060926041406.GE80527@funkthat.com> References: <200609260121.k8Q1Llo8049117@repoman.freebsd.org> <20060925215235.C46437@fledge.watson.org> <20060926041406.GE80527@funkthat.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 25 Sep 2006, John-Mark Gurney wrote: :Andrew R. Reiter wrote this message on Mon, Sep 25, 2006 at 21:53 -0400: :> On Tue, 26 Sep 2006, John-Mark Gurney wrote: :> :> :jmg 2006-09-26 01:21:47 UTC :> : :> : FreeBSD src repository :> : :> : Modified files: :> : sys/netinet tcp_input.c :> : Log: :> : fix calculating to_tsecr... This prevents the rtt calculations from :> : going all wonky... :> : :> : Revision Changes Path :> : 1.309 +1 -1 src/sys/netinet/tcp_input.c :> :> At some point will it be safe to remove that min/max check? : :Do you mean replace the else? or do you mean change it entirely? : :Unless someone can think of a reason why the retransmit timer should :ever be allowed to go above 64 seconds, I'd consider replacing the :else, but as I see it, it prevents run away code, though w/o the :else I probably wouldn't of found this bug... : turn into KASSERT or something -- arr@watson.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060926114811.F46437>