Date: Fri, 5 Mar 2010 21:18:00 +0000 (UTC) From: Doug Barton <dougb@FreeBSD.org> To: Alexander Leidinger <netchild@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r204759 - in head: etc/defaults etc/rc.d share/man/man5 Message-ID: <alpine.BSF.2.00.1003052113350.98935@serrsnyy.serrofq.bet> In-Reply-To: <201003051434.o25EYXBR024375@svn.freebsd.org> References: <201003051434.o25EYXBR024375@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --844893955-1427392154-1267823881=:98935 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed On Fri, 5 Mar 2010, Alexander Leidinger wrote: > Author: netchild > Date: Fri Mar 5 14:34:33 2010 > New Revision: 204759 > URL: http://svn.freebsd.org/changeset/base/204759 I've got no comments on the jail-related stuff given that my knowledge of jails is almost non-existent. However I wish you had run your diff past freebsd-rc@ since if you had I (or someone else) could have let you know that the attached patch is a much cleaner way of implementing the bit about conditionalizing "parallel" execution (which, to the extent I understand the problem I agree with your solution of only doing it at when starting, FWIW). In general we try to avoid having any code in rc.d scripts run unconditionally. In this case it's harmless (although every cpu cycle counts) but in other cases it can cause problems, which is why as a general rule it's safer to avoid it altogether. hth, Doug --844893955-1427392154-1267823881=:98935 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=jail-rc.diff Content-Transfer-Encoding: BASE64 Content-ID: <alpine.BSF.2.00.1003052118000.98935@serrsnyy.serrofq.bet> Content-Description: Content-Disposition: attachment; filename=jail-rc.diff SW5kZXg6IGphaWwNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBqYWls CShyZXZpc2lvbiAyMDQ3NzApDQorKysgamFpbAkod29ya2luZyBjb3B5KQ0K QEAgLTE4LDYgKzE4LDggQEANCiANCiBuYW1lPSJqYWlsIg0KIHJjdmFyPWBz ZXRfcmN2YXJgDQorDQorc3RhcnRfcHJlY21kPSJqYWlsX3ByZXN0YXJ0Ig0K IHN0YXJ0X2NtZD0iamFpbF9zdGFydCINCiBzdG9wX2NtZD0iamFpbF9zdG9w Ig0KIA0KQEAgLTU0NSw2ICs1NDcsMTMgQEANCiAJZG9uZQ0KIH0NCiANCitq YWlsX3ByZXN0YXJ0KCkNCit7DQorCWlmIGNoZWNreWVzbm8gamFpbF9wYXJh bGxlbF9zdGFydDsgdGhlbg0KKwkJY29tbWFuZF9hcmdzPScmJw0KKwlmaQ0K K30NCisNCiBqYWlsX3N0YXJ0KCkNCiB7DQogCWVjaG8gLW4gJ0NvbmZpZ3Vy aW5nIGphaWxzOicNCkBAIC03MzAsMTggKzczOSw0IEBADQogCWphaWxfbGlz dD0iJCoiDQogZmkNCiANCi0jIE9ubHkgYWxsb3cgdGhlIHBhcmFsbGVsIHN0 YXJ0IG9mIGphaWxzLCBvdGhlciBjb21tYW5kcyBhcmUgbm90DQotIyBzYWZl IHRvIGV4ZWN1dGUgaW4gcGFyYWxsZWwuDQotY2FzZSAiJHtjbWR9IiBpbg0K LSpzdGFydCkNCi0JOzsNCi0qKQ0KLQlqYWlsX3BhcmFsbGVsX3N0YXJ0PU5P DQotZXNhYw0KLQ0KLWlmIGNoZWNreWVzbm8gamFpbF9wYXJhbGxlbF9zdGFy dDsgdGhlbg0KLQlydW5fcmNfY29tbWFuZCAiJHtjbWR9IiAmDQotZWxzZQ0K LQlydW5fcmNfY29tbWFuZCAiJHtjbWR9Ig0KLWZpDQotDQorcnVuX3JjX2Nv bW1hbmQgIiR7Y21kfSINCg== --844893955-1427392154-1267823881=:98935--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.1003052113350.98935>