Date: Fri, 26 Jan 2018 08:02:04 +0100 From: Ed Schouten <ed@nuxi.nl> To: Warner Losh <imp@bsdimp.com> Cc: Eitan Adler <eadler@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328430 - head/sbin/devd Message-ID: <CABh_MKnA994NSh%2B8W=aEDGxg5JFWcMZr4EVe-_KHJ8xN9-vkfQ@mail.gmail.com> In-Reply-To: <CANCZdfosuC0CTig=6_p3D5g0fDPhCVW3%2B4HAEbD4EQ4%2B3TetpA@mail.gmail.com> References: <201801260440.w0Q4efhg008105@repo.freebsd.org> <CANCZdfosuC0CTig=6_p3D5g0fDPhCVW3%2B4HAEbD4EQ4%2B3TetpA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
2018-01-26 5:52 GMT+01:00 Warner Losh <imp@bsdimp.com>: > Everything needs a virtual destructor... Please back that part of this > out... If you're concerned about inheritance, what about adding the 'final' keyword to the class? http://en.cppreference.com/w/cpp/language/final Eitan: static void usage(void) __dead2; This should be spelled: [[noreturn]] static void usage(); -- Ed Schouten <ed@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CABh_MKnA994NSh%2B8W=aEDGxg5JFWcMZr4EVe-_KHJ8xN9-vkfQ>