Date: Sat, 4 Apr 2015 10:48:15 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r281055 - head/share/mk Message-ID: <85A796A0-FB31-4B58-BCAA-C48F5DC59ECC@gmail.com> In-Reply-To: <20150404104320.GB20155@ivaldir.etoilebsd.net> References: <201504040031.t340VedI086145@svn.freebsd.org> <BE8F2BEF-DE1D-48DB-B997-8ABDD995C48D@gmail.com> <20150404104320.GB20155@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Apr 4, 2015, at 03:43, Baptiste Daroussin <bapt@FreeBSD.org> wrote: > >> On Fri, Apr 03, 2015 at 05:36:21PM -0700, Garrett Cooper wrote: >>> On Apr 3, 2015, at 17:31, Baptiste Daroussin <bapt@FreeBSD.org> wrote: >>> >>> Author: bapt >>> Date: Sat Apr 4 00:31:40 2015 >>> New Revision: 281055 >>> URL: https://svnweb.freebsd.org/changeset/base/281055 >>> >>> Log: >>> Do not install scripts multiple time when using bsd.progs.mk >>> >>> Modified: >>> head/share/mk/bsd.progs.mk >> >> Ifm sorry Ifve been lax with this, but unfortunately this doesnft solve the underlying issue 100%. >> >> 1. You forgot FILES/FILESGROUPS >> 2. This doesnft help cases were targets are manually overridden. >> 3. Etc. >> >> The project I was working on has reached steady state. We should be done with the big hurdle soon-ish (another month or two). Ifll try to resolve it sometime between now and then by putting all of the PROGS logic down into bsd.prog.mk (where it should have been in the first placec), because bsd.progs.mk being included recursively is a layering violation bug that parallel installs expose. >> >> Thanks! > > Well I have hit this one while packaging base because pkg(8) yell when things > are being packaged twice, so I'm fixing when I see them I plan to fix others > when I'll catch them, if you prefer I can keep that on my own branch to not make > collision with your work? That'd be good. I'll check in the short term minimal hack to fix this today and work on moving bsd.test.mk away from bsd.progs.mk on another branch. Thanks for all the packaging stuff in base BTW -- really looking forward to it :)!!!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?85A796A0-FB31-4B58-BCAA-C48F5DC59ECC>