Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 3 Jun 2023 13:52:57 -0600
From:      Warner Losh <imp@bsdimp.com>
To:        John Baldwin <jhb@freebsd.org>
Cc:        Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>,  "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>,  "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org>
Subject:   Re: git: b8b97d31bda1 - main - pmcstat: Fix typos
Message-ID:  <CANCZdfqyvLmE-AwCejjJ6uLo0QXqEsNjKzmWo%2B-JC5DNSOieag@mail.gmail.com>
In-Reply-To: <d184ef15-6771-6ae0-0c41-e511d47dd3b4@FreeBSD.org>
References:  <202306020233.3522Xmo4005217@gitrepo.freebsd.org> <d184ef15-6771-6ae0-0c41-e511d47dd3b4@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000c2b6d005fd3f0421
Content-Type: text/plain; charset="UTF-8"

On Fri, Jun 2, 2023, 10:45 AM John Baldwin <jhb@freebsd.org> wrote:

> On 6/1/23 7:33 PM, Warner Losh wrote:
> > The branch main has been updated by imp:
> >
> > URL:
> https://cgit.FreeBSD.org/src/commit/?id=b8b97d31bda194cfcdb9c03a1b53d27dfbd884f0
> >
> > commit b8b97d31bda194cfcdb9c03a1b53d27dfbd884f0
> > Author:     Elyes Haouas <ehaouas@noos.fr>
> > AuthorDate: 2023-06-01 23:41:32 +0000
> > Commit:     Warner Losh <imp@FreeBSD.org>
> > CommitDate: 2023-06-02 02:33:39 +0000
> >
> >      pmcstat: Fix typos
> >
> >      Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
> >      Reviewed by: imp
> >      Pull Request: https://github.com/freebsd/freebsd-src/pull/653
> > ---
> >   usr.sbin/pmcstat/pmcstat.c     | 2 +-
> >   usr.sbin/pmcstat/pmcstat_log.c | 2 +-
> >   2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/usr.sbin/pmcstat/pmcstat.c b/usr.sbin/pmcstat/pmcstat.c
> > index fa590432667a..decb2c5af953 100644
> > --- a/usr.sbin/pmcstat/pmcstat.c
> > +++ b/usr.sbin/pmcstat/pmcstat.c
> > @@ -96,7 +96,7 @@ __FBSDID("$FreeBSD$");
> >    *
> >    *   /Parent/                               /Child/
> >    *
> > - *   - Wait for childs token.
> > + *   - Wait for children token.
> >    *                                  - Sends token.
> >    *                                  - Awaits signal to start.
>
> I think this one should be "Wait for child's token."
>

Agreed

Warner

> --
> John Baldwin
>
>

--000000000000c2b6d005fd3f0421
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" =
class=3D"gmail_attr">On Fri, Jun 2, 2023, 10:45 AM John Baldwin &lt;<a href=
=3D"mailto:jhb@freebsd.org">jhb@freebsd.org</a>&gt; wrote:<br></div><blockq=
uote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc =
solid;padding-left:1ex">On 6/1/23 7:33 PM, Warner Losh wrote:<br>
&gt; The branch main has been updated by imp:<br>
&gt; <br>
&gt; URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3Db8b97d31bda1=
94cfcdb9c03a1b53d27dfbd884f0" rel=3D"noreferrer noreferrer" target=3D"_blan=
k">https://cgit.FreeBSD.org/src/commit/?id=3Db8b97d31bda194cfcdb9c03a1b53d2=
7dfbd884f0</a><br>
&gt; <br>
&gt; commit b8b97d31bda194cfcdb9c03a1b53d27dfbd884f0<br>
&gt; Author:=C2=A0 =C2=A0 =C2=A0Elyes Haouas &lt;<a href=3D"mailto:ehaouas@=
noos.fr" target=3D"_blank" rel=3D"noreferrer">ehaouas@noos.fr</a>&gt;<br>
&gt; AuthorDate: 2023-06-01 23:41:32 +0000<br>
&gt; Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh &lt;imp@FreeBSD.org&gt;<br>
&gt; CommitDate: 2023-06-02 02:33:39 +0000<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 pmcstat: Fix typos<br>
&gt;=C2=A0 =C2=A0 =C2=A0 <br>
&gt;=C2=A0 =C2=A0 =C2=A0 Signed-off-by: Elyes Haouas &lt;<a href=3D"mailto:=
ehaouas@noos.fr" target=3D"_blank" rel=3D"noreferrer">ehaouas@noos.fr</a>&g=
t;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 Reviewed by: imp<br>
&gt;=C2=A0 =C2=A0 =C2=A0 Pull Request: <a href=3D"https://github.com/freebs=
d/freebsd-src/pull/653" rel=3D"noreferrer noreferrer" target=3D"_blank">htt=
ps://github.com/freebsd/freebsd-src/pull/653</a><br>
&gt; ---<br>
&gt;=C2=A0 =C2=A0usr.sbin/pmcstat/pmcstat.c=C2=A0 =C2=A0 =C2=A0| 2 +-<br>
&gt;=C2=A0 =C2=A0usr.sbin/pmcstat/pmcstat_log.c | 2 +-<br>
&gt;=C2=A0 =C2=A02 files changed, 2 insertions(+), 2 deletions(-)<br>
&gt; <br>
&gt; diff --git a/usr.sbin/pmcstat/pmcstat.c b/usr.sbin/pmcstat/pmcstat.c<b=
r>
&gt; index fa590432667a..decb2c5af953 100644<br>
&gt; --- a/usr.sbin/pmcstat/pmcstat.c<br>
&gt; +++ b/usr.sbin/pmcstat/pmcstat.c<br>
&gt; @@ -96,7 +96,7 @@ __FBSDID(&quot;$FreeBSD$&quot;);<br>
&gt;=C2=A0 =C2=A0 *<br>
&gt;=C2=A0 =C2=A0 *=C2=A0 =C2=A0/Parent/=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0/Child/<br>
&gt;=C2=A0 =C2=A0 *<br>
&gt; - *=C2=A0 =C2=A0- Wait for childs token.<br>
&gt; + *=C2=A0 =C2=A0- Wait for children token.<br>
&gt;=C2=A0 =C2=A0 *=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 - Sends toke=
n.<br>
&gt;=C2=A0 =C2=A0 *=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 - Awaits sig=
nal to start.<br>
<br>
I think this one should be &quot;Wait for child&#39;s token.&quot;<br></blo=
ckquote></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">Agreed</d=
iv><div dir=3D"auto"><br></div><div dir=3D"auto">Warner</div><div dir=3D"au=
to"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"m=
argin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
-- <br>
John Baldwin<br>
<br>
</blockquote></div></div></div>

--000000000000c2b6d005fd3f0421--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqyvLmE-AwCejjJ6uLo0QXqEsNjKzmWo%2B-JC5DNSOieag>