Date: Wed, 24 Nov 2010 00:01:27 +0100 From: Hans Petter Selasky <hselasky@c2i.net> To: Weongyo Jeong <weongyo@freebsd.org> Cc: freebsd-usb@freebsd.org, Jung-uk Kim <jkim@freebsd.org> Subject: Re: [RFC] USBdump patches Message-ID: <201011240001.27237.hselasky@c2i.net> In-Reply-To: <20101123224002.GH92881@weongyo> References: <AANLkTinaUNi3FGRiOkeTN2FKx3ybqE=F3W6%2BsV8qVCTf@mail.gmail.com> <201011232319.33678.hselasky@c2i.net> <20101123224002.GH92881@weongyo>
next in thread | previous in thread | raw e-mail | index | archive | help
Dear Weongyo, > NACK. You already could recognize that the patch is quite big and > multiple patches are mixed into one. Please separate into smallest > pieces then send freebsd-usb@ again. I don't want to do a jumbo jump. Probably it is easier if you look at the code after you've applied it to SVN. We are talking about a small amount of C-code, < 1000 LOC. I've spent 6-7 hours today alone cleaning up the initial patch from you. I think I've spent 2-3 work-days now in total reviewing and rewriting USB PF. How much effort did you put into the code, hence you are so critical to my changes? --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201011240001.27237.hselasky>