Date: Sat, 6 Aug 2016 07:36:04 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: Pawel Pekala <pawel@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r419716 - in head/games: . zdoom Message-ID: <20160806073604.GD53097@FreeBSD.org> In-Reply-To: <02F62285C025519217DB3167@atuin.in.mat.cc> References: <201608052308.u75N8bQf092339@repo.freebsd.org> <02F62285C025519217DB3167@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 06, 2016 at 02:01:32AM +0200, Mathieu Arnold wrote:
> +--On 5 ao??t 2016 23:08:37 +0000 Pawel Pekala <pawel@FreeBSD.org> wrote:
> | +PLIST_FILES= bin/${PORTNAME} \
> | + %%DATADIR%%/${PORTNAME}.pk3
>
> This should be:
> PLIST_FILES= bin/${PORTNAME} \
> ${DATADIR}/${PORTNAME}.pk3
Why? Now it looks inconsistent:
% make -V PLIST_FILES
bin/zdoom /usr/local/share/zdoom/zdoom.pk3
If your point was to avoid plist substitutions for some reason (if they do
not work in PLIST_FILES it looks like a bug that should be fixed instead),
${DATADIR_REL} still suits better.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160806073604.GD53097>