Date: Tue, 18 Dec 2018 11:46:04 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Toomas Soome <tsoome@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r342151 - head/stand/libsa/zfs Message-ID: <20181218114603.GA65077@FreeBSD.org> In-Reply-To: <201812160858.wBG8wFSd032964@repo.freebsd.org> References: <201812160858.wBG8wFSd032964@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Dec 16, 2018 at 08:58:15AM +0000, Toomas Soome wrote: > New Revision: 342151 > URL: https://svnweb.freebsd.org/changeset/base/342151 > > Log: > loader: zfs reader should not probe partitionless disks > > @@ -527,10 +527,11 @@ zfs_probe_dev(const char *devname, uint64_t *pool_guid > pa.fd = open(devname, O_RDONLY); > if (pa.fd == -1) > return (ENXIO); > - /* Probe the whole disk */ > - ret = zfs_probe(pa.fd, pool_guid); > - if (ret == 0) > - return (0); > + /* > + * We will not probe the whole disk, we can not boot from such I think you mean "cannot" here. > + * disks and some systems will misreport the disk sizes and will > + * hang while accessing the disk. > + */ ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181218114603.GA65077>