Date: Wed, 24 Apr 2019 07:21:43 -0700 From: Greg Lewis <glewis@eyesbeyond.com> To: Mathieu Arnold <mat@freebsd.org> Cc: Greg Lewis <glewis@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r499685 - head/java/openjdk8 Message-ID: <20190424142142.GA71685@misty.eyesbeyond.com> In-Reply-To: <20190423165837.zsc7awsmfh423nab@ogg.in.absolight.net> References: <201904222052.x3MKqqVH050067@repo.freebsd.org> <20190423074622.puxd7fibzxx3xvmr@atuin.in.mat.cc> <20190423162725.GA57876@misty.eyesbeyond.com> <20190423165837.zsc7awsmfh423nab@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Apr 23, 2019 at 06:58:37PM +0200, Mathieu Arnold wrote: > On Tue, Apr 23, 2019 at 09:27:25AM -0700, Greg Lewis wrote: > > On Tue, Apr 23, 2019 at 09:46:22AM +0200, Mathieu Arnold wrote: > > > On Mon, Apr 22, 2019 at 08:52:52PM +0000, Greg Lewis wrote: > > > > Author: glewis > > > > Date: Mon Apr 22 20:52:52 2019 > > > > New Revision: 499685 > > > > URL: https://svnweb.freebsd.org/changeset/ports/499685 > > > > > > > > Log: > > > > Always depend on fontconfig > > > > > > > > PR: 203862 > > > > Submitted by: Dominik Lisiak <dominik.lisiak@bemsoft.pl> > > > > > > You need to bump PORTREVISION when you change the runtime dependencies. > > > > I didn't bump it since this is a build fix. I.e., we fail the configure > > step without the dependency. If that still requires a PORTREVISION bump > > then I think the porters handbook could use with some clarification on > > the topic. > > Then it does not, but nothing in the commit message could give any hint > that it was fixing the build, and not simply registering a dependency > correctly. That's fair. I didn't pull in the context from the PR to the commit message. Will try to do so in future. -- Greg
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190424142142.GA71685>