Date: Wed, 22 Feb 2023 22:23:49 -0800 From: "Simon J. Gerraty" <sjg@juniper.net> To: Mark Millard <marklmi@yahoo.com> Cc: Bryan Drewery <bdrewery@FreeBSD.org>, Current FreeBSD <freebsd-current@FreeBSD.org>, Peter <pmc@citylink.dinoex.sub.org>, <sjg@juniper.net> Subject: Re: FYI: Why META_MODE rebuilds so much for building again after installworld (no source changes) Message-ID: <72419.1677133429@kaos.jnpr.net> In-Reply-To: <27790339-240F-4C97-97C7-38AFD8DE03D5@yahoo.com> References: <B74790D9-FBC2-4818-BEAF-34E5B705C460@yahoo.com> <3345EBA5-A09C-4E3F-B94D-39F57F56BDBB@yahoo.com> <DB0C7B41-2101-4C5C-BFC8-3C95CC0B9F6F@yahoo.com> <73088.1611797582@kaos.jnpr.net> <CB7040D0-3BF4-496F-A54F-87E5378016E0@yahoo.com> <F6BF110D-7855-4A10-A53F-52B34282234F@yahoo.com> <10819.1677108389@kaos.jnpr.net> <76FA98EF-6184-4D7E-A01F-0EE8117D0D10@yahoo.com> <29887.1677115125@kaos.jnpr.net> <27790339-240F-4C97-97C7-38AFD8DE03D5@yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Mark Millard <marklmi@yahoo.com> wrote:
> >
> > Is there anything under ${OBJTOP}/tmp that you don't want to ignore?
>
> More than just _bootstrap_tools_links entries end up in
> ${WORLDTMP}/legacy/bin/ (so in ${WORLDTMP}/legacy/sbin/
> via the symbolic link pointing to ${WORLDTMP}/legacy/bin/ ).
> So: yes.
>
> Also, OBJTOP is not constant over all the parts of
> buildworld buildkernel . Having the late-substitution
> form of notation ${OBJTOP} might not be appropriate
> for the content of .MAKE.META.IGNORE_PATHS .
Fwiw .MAKE.META.IGNORE_PATHS is evaluated when meta_init() is
called after all the makefiles have been read - and had a
chance to influence .MAKE.MODE, so I'm not sure how varaiablity of
OBJTOP would matter?
> > .MAKE.META.IGNORE_PATHS+= ${OBJTOP}/tmp/
>
> (Ignoring the variability of OBJTOP issue . . .)
>
> I do not expect that would work: ignoring things
> it likely should not.
Sure, but it may be useful as an experiment to ensure things are
behaving as expected.
> Also, I'd rather grow a smaller set of ignores
> gradually to make it easier to detect if an
> addition starts causing a problem and can be
> backed out. Starting with everything ignored
> would make things much harder to figure out
> when ignoring creates a problem.
Yes.
>
> > You might need ${OBJTOP:tA}/tmp/
> > or both.
I found it necessary in the unit tests to add :tA to both TMPDIR
and .OBJDIR to get sane result on one test platform.
> >> It is using paths that match the -dM output lines ( sbin
> >> use despite sbin -> ../bin being a symbolic link).
use :tA if you want to ensure consistent results.
> > I really need to add some unit-tests for these...
Done - not yet imported to FreeBSD though
> You may want to wait while I see if I can come up with
> a better example context to show things. I only just
> noticed the late-substitution potential issue and
> started looking for a way to avoid it, for example.
> (Either a value that does not vary or a form of
> causing up-front substitutions in my make.conf .)
Ok
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?72419.1677133429>