Date: Wed, 4 Sep 2024 11:34:30 +0200 From: Mathieu Arnold <mat@freebsd.org> To: Gleb Popov <arrowd@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: f71ee5b13c08 - main - Uses/electronfix.mk: Replace .error with .warning to unbreak make describe Message-ID: <oooymztnusoejzveyrc7v4rn76hj627swoajvpehnrd3rdxrzw@wuj7pu5cadc4> In-Reply-To: <202409040903.48493T9P023776@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Wed, Sep 04, 2024 at 09:03:29AM GMT, Gleb Popov wrote: > The branch main has been updated by arrowd: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=f71ee5b13c081f8924986ba52a32396c87138f99 > > commit f71ee5b13c081f8924986ba52a32396c87138f99 > Author: Gleb Popov <arrowd@FreeBSD.org> > AuthorDate: 2024-09-04 09:02:03 +0000 > Commit: Gleb Popov <arrowd@FreeBSD.org> > CommitDate: 2024-09-04 09:03:08 +0000 > > Uses/electronfix.mk: Replace .error with .warning to unbreak make describe > > Reported by: Tomoaki AOKI <junchoon@dec.sakura.ne.jp> > --- > Mk/Uses/electronfix.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Mk/Uses/electronfix.mk b/Mk/Uses/electronfix.mk > index f5e33da516cb..534321ae56ca 100644 > --- a/Mk/Uses/electronfix.mk > +++ b/Mk/Uses/electronfix.mk > @@ -24,7 +24,7 @@ _INCLUDE_USES_ELECTRONFIX_MK= yes > _ELECTRON_MAKEFILE_VERSION= ${.CURDIR}/../../devel/electron${electronfix_ARGS}/Makefile.version > > . if !exists(${_ELECTRON_MAKEFILE_VERSION}) > -. error Unknown Electron version in USES=electronfix:${electronfix_ARGS} > +. warning Unknown Electron version in USES=electronfix:${electronfix_ARGS} > . endif > > BUILD_DEPENDS+= electron${electronfix_ARGS}:devel/electron${electronfix_ARGS} This makes little sense, the .error was there to stop whatever was being done because it's wrong, now it only warns and then goes further and breaks INDEX. Put back the .error and fix the port(s) that are wrong. -- Mathieu Arnold [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmbYKaRfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb6NVAv+I7PtkEUJ+hsMFATyHrBdsDF2OyGyUMyRTjjnxwc/+gsld7hlM/dfjQB7 GZXUyQ4FVxwxgVXNez5M5sVWUZfmZaM8NgIHwNFn2bL8uKMCpe1MXu3nX9gZBVvX 0Wbft7jLClK/ZUqnOk/xDQN0BusMLbN9RgDl1SSW39b9Rt8TLlhRCbF/USOBxsac br4y7hIM9u8f3LjBBF4HWiYuPM36PNo4KhwVJVibSA80aG4iHZ9a/UIyt05Ipv4R fwm3bvQ0p4ObrEtz/3/bOkG5yRoTAQMUi1HQrnatKjClqsW5bXy3yIqGPgEbyJ06 y2Gtz4ZgDyJKT4V007IfSDqyAWNMQJtoRs5zw3ksLuXREptPKTsBiAktHa1XxtX4 gg1bWz+S9YLgNDGKC+p8Rp1IDWEMgl5hGBk9TPJ3OukWX/61FVk98hym5Tz9P2bp BVUdoQapkzOclSYzbfcYFC2DTaa9d8aRHdR1u5mdMX/i6ISU0s8dpZKt26PAVy1v eCQE87li =JWYs -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?oooymztnusoejzveyrc7v4rn76hj627swoajvpehnrd3rdxrzw>