Date: Sat, 06 Aug 2016 09:38:30 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Pawel Pekala <pawel@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r419716 - in head/games: . zdoom Message-ID: <3DA12F22975D816013905296@atuin.in.mat.cc> In-Reply-To: <20160806073604.GD53097@FreeBSD.org> References: <201608052308.u75N8bQf092339@repo.freebsd.org> <02F62285C025519217DB3167@atuin.in.mat.cc> <20160806073604.GD53097@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--==========8A2A682E427F0DD1B403==========
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
+--On 6 ao=C3=BBt 2016 07:36:04 +0000 Alexey Dokuchaev <danfe@FreeBSD.org>
wrote:
| On Sat, Aug 06, 2016 at 02:01:32AM +0200, Mathieu Arnold wrote:
|> +--On 5 ao??t 2016 23:08:37 +0000 Pawel Pekala <pawel@FreeBSD.org> =
wrote:
|> | +PLIST_FILES=3D bin/${PORTNAME} \
|> | + %%DATADIR%%/${PORTNAME}.pk3
|>=20
|> This should be:
|> PLIST_FILES=3D bin/${PORTNAME} \
|> ${DATADIR}/${PORTNAME}.pk3
|=20
| Why? Now it looks inconsistent:
|=20
| % make -V PLIST_FILES
| bin/zdoom /usr/local/share/zdoom/zdoom.pk3
|=20
| If your point was to avoid plist substitutions for some reason (if they =
do
| not work in PLIST_FILES it looks like a bug that should be fixed =
instead),
| ${DATADIR_REL} still suits better.
Substitutions are there for one reason only, to be able to carry variables
from the Makefile to the pkg-plist file. DATADIR is just fine, it is the
full path to the file, which is supported.
--=20
Mathieu Arnold
--==========8A2A682E427F0DD1B403==========
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQJ8BAEBCgBmBQJXpZP2XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85I30UP/3ARKELzp9ED96+9Txu/d55r
QaQUU7QHpq0GlImKkXuTRGOyyVBcw2IDRQ9JUOsSvy2NEqOBMbdWXCY9SfK3Hj+o
H3alyV6EFdF69H8AA90zuWYELhcGA5f2v20E0cvXHBXVQ61w43Qxn0xn2+mq191J
4atrVP4ftEOeNtDHwXrfss7PZz3UqeXox8Vj7FLdYQ0NFWkge2XceZNdOcWHISkZ
c1h9b2jOeiYtL0uQISt2k2Z/+Qk66B6qCOZqdLK32U1hb6WhASaREPVBBlFXcRVD
TG2VQDqT6HOlCSBrZhvNPQWg1CkzE/gJlIdCnjB+MjD2NJ9nmcrmvKvrqE4LUIPW
P8suw7xJ3zlTPbVx7Nxhv62myD9890eTC8ulZwtGs7QSzjz9lKxwPzvocRJYOkHN
veXxaVjovW7TRye6BN3CmssPKb4JrCF0X5h/jr8VGJu7ODZyjPNVWNeE9F2uQaxI
mfOZ80vA2KgNhAozqxaMQbeWr2aKaiVBNGDLlWXM2R7BSkxbiSviHt9gtaDS6p7L
3XTN8VmDusD2hVaos599/mKNS+rGh6uGS/9E+f3x/Za7TydQ0Hx/BsOYVmEnOLu3
G/oVgOcZrpNpcr0UYhbSDWhr6f1Ut0mrhhfY8dS8V4dENRUPM/yruxHgkKo0HGep
nE9QEwAOTQHJ2pqPMqvp
=8wOG
-----END PGP SIGNATURE-----
--==========8A2A682E427F0DD1B403==========--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3DA12F22975D816013905296>