Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 4 Mar 2023 14:58:57 GMT
From:      Mike Karels <karels@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 009abff336b6 - stable/13 - growfs_fstab startup script: set dumpdev to AUTO
Message-ID:  <202303041458.324EwveO037244@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by karels:

URL: https://cgit.FreeBSD.org/src/commit/?id=009abff336b6e83219178e7d87f6a91f54e31839

commit 009abff336b6e83219178e7d87f6a91f54e31839
Author:     Mike Karels <karels@FreeBSD.org>
AuthorDate: 2023-02-28 13:55:35 +0000
Commit:     Mike Karels <karels@FreeBSD.org>
CommitDate: 2023-03-04 14:58:41 +0000

    growfs_fstab startup script: set dumpdev to AUTO
    
    The growfs_fstab script has been testing dumpdev, and if it is AUTO,
    enables dumps on the newly-added swap device for the initial boot.
    However, dumpdev defaults to AUTO on main, but NO on stable/13 and
    release branches.  On the other hand, bsdinstall adds dumpdev="AUTO"
    by default (controlled by a menu item).  bsdinstall is not used when
    booting an SD card or other disk image.  Adopt the default from
    bsdinstall, and set dumpdev to AUTO in /etc/rc.conf in the
    growfs_fstab script if a swap partition has been added, along with
    the explanatory comment added by bsdinstall.
    
    Differential Revision:  https://reviews.freebsd.org/D38751
    
    (cherry picked from commit eef9f9900f118b5efcabbd5864e7b8b993d09922)
---
 libexec/rc/rc.d/growfs_fstab | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/libexec/rc/rc.d/growfs_fstab b/libexec/rc/rc.d/growfs_fstab
index 8ad34f452ce0..c51f0dd6f3de 100755
--- a/libexec/rc/rc.d/growfs_fstab
+++ b/libexec/rc/rc.d/growfs_fstab
@@ -51,14 +51,9 @@ growfs_fstab_start()
 		    ' < /etc/fstab
 		then
 			printf "/dev/label/growfs_swap\tnone\t\tswap\tsw\t\t0\t0\n" >>/etc/fstab
-
-			case "$dumpdev" in
-			[Aa][Uu][Tt][Oo])
-				dumpon $dumpon_flags /dev/label/growfs_swap
-				;;
-			*)
-				;;
-			esac
+			printf '# Set dumpdev to "AUTO" to enable crash dumps, "NO" to disable\n' >>/etc/rc.conf
+			printf 'dumpdev="AUTO"\n' >>/etc/rc.conf
+			dumpon $dumpon_flags /dev/label/growfs_swap
 		fi
 	fi
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202303041458.324EwveO037244>