Date: Wed, 19 Apr 2017 14:47:31 -0400 From: Ed Maste <emaste@freebsd.org> To: rgrimes@freebsd.org Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r317145 - in stable/11/sys: boot/mips/uboot conf Message-ID: <CAPyFy2BD5ss0XsFQ95=_jZm8RjStg5RLOtVmy3K-zZcZEsdnyQ@mail.gmail.com> In-Reply-To: <201704191624.v3JGOImX031395@pdx.rh.CN85.dnsmgr.net> References: <201704191533.v3JFXOHk065533@repo.freebsd.org> <201704191624.v3JGOImX031395@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 19 April 2017 at 12:24, Rodney W. Grimes <freebsd@pdx.rh.cn85.dnsmgr.net> wrote: >> >> The linker script CONSTRUCTORS keyword is only meaningful "when linking >> object file formats which do not support arbitrary sections, such as >> ECOFF and XCOFF"[1] and is ignored for other object file formats. >> >> LLVM's lld does not yet accept (and ignore) CONSTRUCTORS, so just remove >> CONSTRUCTORS from the linker script as it has no effect. >> >> [1] https://sourceware.org/binutils/docs/ld/Output-Section-Keywords.html > > ^^^^^^^^^^^^ links to external data is probably not a good idea in > commit messages as it tends to disappear in time. I understand your point, but think it should be phrased differently: commit messages should stand alone. Some projects use a commit message style that consists of little more than "Fixes bug #1723" or "rdar://90210", and I agree that is insufficient. In the quoted commit message above the relevant content from the binutils documentation is quoted inline, and the URL acts as a reference for the citation. I'd argue that a citation without the URL is less useful today, and not really any worse in the case that sourceware.org disappears, given the existence of the Internet Archive and search engines that could locate the content based on the quoted content and/or portions of the URL.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2BD5ss0XsFQ95=_jZm8RjStg5RLOtVmy3K-zZcZEsdnyQ>