Date: Thu, 09 Oct 2014 21:51:54 -0700 From: Peter Wemm <peter@wemm.org> To: Baptiste Daroussin <bapt@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r272827 - head Message-ID: <1467763.xYzL2ym5JW@overcee.wemm.org> In-Reply-To: <201410091552.s99Fq1jI059329@svn.freebsd.org> References: <201410091552.s99Fq1jI059329@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Thursday, October 09, 2014 03:52:01 PM Baptiste Daroussin wrote: > Author: bapt > Date: Thu Oct 9 15:52:01 2014 > New Revision: 272827 > URL: https://svnweb.freebsd.org/changeset/base/272827 > > Log: > Add size(1) to the cross build toolchain > > Modified: > head/Makefile.inc1 > > Modified: head/Makefile.inc1 > ============================================================================ > == --- head/Makefile.inc1 Thu Oct 9 15:35:28 2014 (r272826) > +++ head/Makefile.inc1 Thu Oct 9 15:52:01 2014 (r272827) > @@ -315,7 +315,7 @@ X${COMPILER}?= ${CROSS_COMPILER_PREFIX}$ > X${COMPILER}?= ${${COMPILER}} > .endif > .endfor > -XBINUTILS= AS AR LD NM OBJCOPY OBJDUMP RANLIB STRINGS > +XBINUTILS= AS AR LD NM OBJCOPY OBJDUMP RANLIB SIZE STRINGS > .for BINUTIL in ${XBINUTILS} > .if defined(CROSS_BINUTILS_PREFIX) > X${BINUTIL}?= ${CROSS_BINUTILS_PREFIX}${${BINUTIL}} > @@ -327,7 +327,8 @@ WMAKEENV+= CC="${XCC} ${XFLAGS}" CXX="${ > CPP="${XCPP} ${XFLAGS}" \ > AS="${XAS}" AR="${XAR}" LD="${XLD}" NM=${XNM} \ > OBJDUMP=${XOBJDUMP} OBJCOPY="${XOBJCOPY}" \ > - RANLIB=${XRANLIB} STRINGS=${XSTRINGS} > + RANLIB=${XRANLIB} STRINGS=${XSTRINGS} \ > + SIZE="${XSIZE}" > > .if ${XCC:M/*} > XFLAGS= --sysroot=${WORLDTMP} This broke 'make buildkernel'. kern.pre.mk: SIZE?= size kern.post.mk: SYSTEM_LD_TAIL= @${OBJCOPY} --strip-symbol gcc2_compiled. ${.TARGET} ; \ ${SIZE} ${.TARGET} ; chmod 755 ${.TARGET} This is getting executed as: objcopy --strip-symbol gcc2_compiled. .kernel ; kernel ; chmod 755 kernel ie: "kernel" instead of "size kernel". XSIZE isn't set for the non-cross case. -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI6FJV UTF-8: for when a ' or ... just won\342\200\231t do\342\200\246 [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABAgAGBQJUN2XuAAoJEDXWlwnsgJ4EX40H/0ctx2Usk7lmFHsXce4VrTr1 M8MeUimo+CRYsLJcOU9h7B6nVLMTOEREHMBTDx66SbAP/x9RoROLLkAk5dSqLu+E qfjAcYH8bW0dQX6msHJ8x6hStMHVeC4zuvB8z4/yEWk/C7sgMb+Qg/Tc7ydr+qbe Eig8bSbgWqJBuU76v6iKvQNKJ6EmKXU32Rl/cI5B1OSmH1QYphxaOOscdXBZR+sr pAjmOHOiqa38XG5XB+hYqE8Gaqtw9paBp7zhlBvqkgcetRQGHz5RSWRSH1Zc0RHK sZcJr5zktuaRZnQw1d+hHoxObSZST6woT9JiG4XJkgC4jOqqojJhp4YQtHfIgiA= =CK84 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1467763.xYzL2ym5JW>