Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 01 Dec 2017 13:35:23 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 224019] [netgraph] [patch] ng_patch is broken in 10.4-RELEASE
Message-ID:  <bug-224019-8@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D224019

            Bug ID: 224019
           Summary: [netgraph] [patch] ng_patch is broken in 10.4-RELEASE
           Product: Base System
           Version: 10.4-RELEASE
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Some People
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: sd@mostnet.ru
          Keywords: patch

Created attachment 188448
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D188448&action=
=3Dedit
patch

Steps to Reproduce:
#ngctl mkpeer ipfw: patch 7 in
#ngctl name ipfw:7 tcp_rst
#ngctl connect ipfw: tcp_rst: 8 out
#ngctl msg tcp_rst: setconfig { count=3D1 csum_flags=3D0 ops=3D[ { mode=3D8=
 value=3D4
length=3D1 offset=3D33 } ] }
ngctl: send msg: Argument list too long

Related bug #206185.

It's broken after base r309389 and could be fixed in base r309408, but the
first one went to 10.4 and the second one didn't.

11.0 didn't get this patches, 11.1 got both, so they are OK.

Patch to fix (also attached):
--- /sys/netgraph/ng_patch.h.orig       2017-11-23 14:19:54.019040000 +0300
+++ /sys/netgraph/ng_patch.h    2017-12-01 16:21:56.000000000 +0300
@@ -86,7 +86,7 @@

 #define        NG_PATCH_CONFIG_TYPE_INFO {=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20
\
        { "count",              &ng_parse_uint32_type           },      \
-       { "csum_flags",         &ng_parse_uint64_type           },      \
+       { "csum_flags",         &ng_parse_uint32_type           },      \
        { "ops",                &ng_patch_ops_array_type                },=
=20=20=20=20=20
\
        { NULL }                                                        \
 }

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-224019-8>