Date: Mon, 9 Jan 2012 23:31:11 +0300 From: Sergey Kandaurov <pluknet@freebsd.org> To: Dimitry Andric <dim@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Devin Teske <devin.teske@fisglobal.com> Subject: Re: svn commit: r228985 - head/sys/boot/forth Message-ID: <CAE-mSOJHWxXcgiCyJ8kwO5rqjrAR1kLD-YPKPcjrYV3d1jrq_w@mail.gmail.com> In-Reply-To: <4F0AE274.8010907@FreeBSD.org> References: <201112300624.pBU6OxO9098906@svn.freebsd.org> <4F08A518.8090207@FreeBSD.org> <CAE-mSOJS5a%2BxCTFmtUL3R%2B3VZJupgDo7eFbAc70wmtWRW6s-3Q@mail.gmail.com> <4F0AE274.8010907@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9 January 2012 16:49, Dimitry Andric <dim@freebsd.org> wrote: > On 2012-01-08 21:35, Sergey Kandaurov wrote: > ... > >> So, the problem arise when beastie_disable is set. >> >> In this case menu.rc is not evaluated and consequently menu-unset does >> not have a body yet. This results in the ficl warning "not found" when >> try-menu-unset calls menu-unset. The warning cannot be handled with catc= h >> as seen with the code in head. >> Otherwise, when beastie is enabled, all works as it should. >> >> To "fix" the problem I replaced 'catch' with 'sfind', so that we can >> conditionally call menu-unset only when the definition is present. >> >> Please try the following patch. I tested it with enabled/disabled beasti= e >> and loader_color over serial console. I would also like to get a review >> from Devin Teske to see if this change is acceptable. > > > Yes, this patch makes the warning disappear. =A0Thanks! FYI, committed in r229881. Thanks for the help. --=20 wbr, pluknet
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAE-mSOJHWxXcgiCyJ8kwO5rqjrAR1kLD-YPKPcjrYV3d1jrq_w>