Date: Thu, 14 Jul 2016 21:54:33 -0700 From: Cy Schubert <Cy.Schubert@komquats.com> To: Cy Schubert <cy@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r302865 - head Message-ID: <201607150454.u6F4sXK8006100@slippy.cwsent.com> In-Reply-To: Message from Cy Schubert <cy@FreeBSD.org> of "Fri, 15 Jul 2016 04:43:38 -0000." <201607150443.u6F4hcan060828@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <201607150443.u6F4hcan060828@repo.freebsd.org>, Cy Schubert writes: > Author: cy > Date: Fri Jul 15 04:43:38 2016 > New Revision: 302865 > URL: https://svnweb.freebsd.org/changeset/base/302865 > > Log: > When building multiple kernels using KERNCONF, non-existent KERNCONF > files will produce an error and buildkernel will fail. Previously missing > KERNCONF files silently failed giving no indication as to why, only to > subsequently discover during installkernel that the desired kernel was > never built in the first place. > > Reviewed by: ngie@ > MFC after: 1 week > Differential Revision: D7167 > > Modified: > head/Makefile.inc1 > > Modified: head/Makefile.inc1 > ============================================================================= > = > --- head/Makefile.inc1 Fri Jul 15 04:42:08 2016 (r302864) > +++ head/Makefile.inc1 Fri Jul 15 04:43:38 2016 (r302865) > @@ -1140,6 +1140,8 @@ BUILDKERNELS+= ${_kernel} > .if empty(INSTALLKERNEL) && !defined(NO_INSTALLKERNEL) > INSTALLKERNEL= ${_kernel} > .endif > +.else > +.error Missing KERNCONF ${KERNCONFDIR}/${_kernel} > .endif > .endfor > > Ngie@ suggested that this also be a relnotes candidate. I'm not sure if I'd go so far. I'll leave it open for discussion or if re@ wants to. -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201607150454.u6F4sXK8006100>