Date: Wed, 24 Feb 2010 02:19:20 +0100 From: Cyrille Lefevre <cyrille.lefevre-lists@laposte.net> To: Doug Barton <dougb@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, freebsd-rc@FreeBSD.org, Hajimu UMEMOTO <ume@FreeBSD.org> Subject: Re: svn commit: r200743 - in head/usr.sbin: . service Message-ID: <4B847E98.5040209@laposte.net> In-Reply-To: <4B2E84CF.2060902@FreeBSD.org> References: <200912200134.nBK1YCAA048942@svn.freebsd.org> <yged42ackpc.wl%ume@mahoroba.org> <4B2DBB51.9060002@FreeBSD.org> <ygebphuceaw.wl%ume@mahoroba.org> <4B2DD2A1.8060907@FreeBSD.org> <ygeaaxec7oz.wl%ume@mahoroba.org> <4B2E84CF.2060902@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Doug Barton a =E9crit : > I agree to making the change you suggested, but I would like to > quibble over the format. Isn't the attached patch equivalent, and > simpler? What is the value of setting HOME and PATH in the environment > if we're just going to use 'env -i HOME PATH' anyway? how about to replace $* by "$@" in service.sh and to quote $dir/$script=20 as well ? before : exec env -i HOME=3D/ PATH=3D/sbin:/bin:/usr/sbin:/usr/bin $dir/$script $*= after : exec env -i HOME=3D/ PATH=3D/sbin:/bin:/usr/sbin:/usr/bin "$dir/$script" = "$@" Regards, Cyrille Lefevre --=20 mailto:Cyrille.Lefevre-lists@laposte.net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B847E98.5040209>