Date: Wed, 13 Aug 2014 12:06:11 -0400 From: Adam Weinberger <adamw@adamw.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Carlo Strub <cs@FreeBSD.org>, vanilla@FreeBSD.org Subject: Re: svn commit: r364753 - in head/www/gatling: . files Message-ID: <079E1977-AEC8-4B15-856E-DFC3A1D16FD6@adamw.org> In-Reply-To: <0F2D6AC291CD1849F46DBCD4@ogg.in.absolight.net> References: <201408130315.s7D3FWYs042556@svn.freebsd.org> <1407942463.639247.546514528.132749.2@c-st.net> <20140813152833.GA90841@FreeBSD.org> <0F2D6AC291CD1849F46DBCD4@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 13 Aug, 2014, at 11:41, Mathieu Arnold <mat@FreeBSD.org> wrote: >=20 >=20 > +--On 13 ao=FBt 2014 15:28:33 +0000 Alexey Dokuchaev = <danfe@FreeBSD.org> > wrote: > | On Wed, Aug 13, 2014 at 05:07:43PM +0200, Carlo Strub wrote: > |> 13/08/2014 05:16 - Vanilla I. Shu wrote: > |> > New Revision: 364753 > |> > URL: http://svnweb.freebsd.org/changeset/ports/364753 > |> > QAT: https://qat.redports.org/buildarchive/r364753/ > |> >=20 > |> > [...] > |> > -OPTIONS_DEFINE=3D BENCHMARKS SMB TLS ZLIB OPTIMIZED_CFLAGS > |> > -OPTIONS_DEFAULT=3D BENCHMARKS SMB TLS ZLIB OPTIMIZED_CFLAGS > |> > +OPTIONS_DEFINE=3D BENCHMARKS SMB TLS ZLIB OPTIMIZED_CFLAGS DOCS > |> > EXAMPLES DEBUG +OPTIONS_SUB=3D yes > |> > +OPTIONS_DEFAULT=3D BENCHMARKS SMB TLS ZLIB OPTIMIZED_CFLAGS DOCS > |> > EXAMPLES > |>=20 > |> These large changes, especially the new options, merit a = PORTREVISION > |> bump, no? > |=20 > | No, why? Default options already include DOCS and EXAMPLES; the = above > | change in OPTIONS_DEFAULT is actually useless. >=20 > OPTIONS_DEFAULT, yes, but they were not present in OPTIONS_DEFINE, = thus > were not there. There should have been a PORTREVISION bump with this > change. >=20 > --=20 > Mathieu Arnold >=20 And while you=92re bumping PORTREVISION, can you please unmute the = installation commands? And put parentheses around your compound commands = (cd ${WRKSRC} && ${INSTALL...) # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?079E1977-AEC8-4B15-856E-DFC3A1D16FD6>