Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 20 Jan 2016 13:59:05 -0800
From:      Warner Losh <imp@bsdimp.com>
To:        Bryan Drewery <bdrewery@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r294444 - in head/sys/modules: ix ixlv ixv
Message-ID:  <5CEF44A4-3121-4A16-AB52-84CACB3F2C7F@bsdimp.com>
In-Reply-To: <56A002DA.5030003@FreeBSD.org>
References:  <201601201645.u0KGjeN2029336@repo.freebsd.org> <56A002DA.5030003@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help 

--Apple-Mail=_2819A333-EE9E-433F-9391-3AB3E290FC11
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

It would work built part of buildkernel since pci_iov_if.h would exist =
there. It would fail when built by hand since the kernel config didn=E2=80=
=99t save us.

Warner


> On Jan 20, 2016, at 1:57 PM, Bryan Drewery <bdrewery@FreeBSD.org> =
wrote:
>=20
> I have no idea how this was working before and why it took so long to
> manifest. Many people reported failures here in the last day and
> confirmed this fixed it.
>=20
> On 1/20/2016 8:45 AM, Bryan Drewery wrote:
>> Author: bdrewery
>> Date: Wed Jan 20 16:45:39 2016
>> New Revision: 294444
>> URL: https://svnweb.freebsd.org/changeset/base/294444
>>=20
>> Log:
>>  Add some missing dependencies on pci_iov_if.h.
>>=20
>>  Sponsored by:	EMC / Isilon Storage Division
>>=20
>> Modified:
>>  head/sys/modules/ix/Makefile
>>  head/sys/modules/ixlv/Makefile
>>  head/sys/modules/ixv/Makefile
>>=20
>> Modified: head/sys/modules/ix/Makefile
>> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>> --- head/sys/modules/ix/Makefile	Wed Jan 20 16:41:00 2016	=
(r294443)
>> +++ head/sys/modules/ix/Makefile	Wed Jan 20 16:45:39 2016	=
(r294444)
>> @@ -3,7 +3,7 @@
>> .PATH:  ${.CURDIR}/../../dev/ixgbe
>>=20
>> KMOD    =3D if_ix
>> -SRCS    =3D device_if.h bus_if.h pci_if.h
>> +SRCS    =3D device_if.h bus_if.h pci_if.h pci_iov_if.h
>> SRCS	+=3D opt_inet.h opt_inet6.h opt_rss.h
>> SRCS    +=3D if_ix.c ix_txrx.c ixgbe_osdep.c
>> # Shared source
>>=20
>> Modified: head/sys/modules/ixlv/Makefile
>> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>> --- head/sys/modules/ixlv/Makefile	Wed Jan 20 16:41:00 2016	=
(r294443)
>> +++ head/sys/modules/ixlv/Makefile	Wed Jan 20 16:45:39 2016	=
(r294444)
>> @@ -3,7 +3,7 @@
>> .PATH:  ${.CURDIR}/../../dev/ixl
>>=20
>> KMOD    =3D if_ixlv
>> -SRCS    =3D device_if.h bus_if.h pci_if.h opt_bdg.h
>> +SRCS    =3D device_if.h bus_if.h pci_if.h pci_iov_if.h opt_bdg.h
>> SRCS    +=3D opt_inet.h opt_inet6.h opt_rss.h
>> SRCS    +=3D if_ixlv.c ixlvc.c ixl_txrx.c i40e_osdep.c
>>=20
>>=20
>> Modified: head/sys/modules/ixv/Makefile
>> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>> --- head/sys/modules/ixv/Makefile	Wed Jan 20 16:41:00 2016	=
(r294443)
>> +++ head/sys/modules/ixv/Makefile	Wed Jan 20 16:45:39 2016	=
(r294444)
>> @@ -3,7 +3,7 @@
>> .PATH:  ${.CURDIR}/../../dev/ixgbe
>>=20
>> KMOD    =3D if_ixv
>> -SRCS    =3D device_if.h bus_if.h pci_if.h
>> +SRCS    =3D device_if.h bus_if.h pci_if.h pci_iov_if.h
>> SRCS	+=3D opt_inet.h opt_inet6.h opt_rss.h
>> SRCS    +=3D if_ixv.c ix_txrx.c ixgbe_osdep.c
>> # Shared source
>>=20
>=20
>=20
> --
> Regards,
> Bryan Drewery
>=20


--Apple-Mail=_2819A333-EE9E-433F-9391-3AB3E290FC11
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org

iQIcBAEBCgAGBQJWoAMpAAoJEGwc0Sh9sBEASWwQAIE/J/zxk6L638z7vNw40N2H
8O7+ZWuGAGeIam4Dhlllu+utpH3RFBxztSWnYQrxETrBMpnlNNh60p5H0rUCbpNI
WD4BU8Adlll6xomw1OHJXCDTRqj+ilaKbIsPt9ALJfdpEOfPzqASzKeem9Jl7t6W
/axVtEA7sQJbjS4Dny2ocT9+6J7Pk9fmXEtdT54peVXFUOl4/9cqCDf+hlmrQOQM
hz2e0idGV+5Mwvgf/kihSf+3CJ3o/jGAgDXLSqEEJCzwRcVDopbNcKl9hjJwnzbt
gL1YIYNV3aN/IICtbrIne+bDlllY6U3zfhLLKX4b1bgotWJypMri8dCKCx0weKKm
1zL+oeLPGG5S6cWPMTKtxjhFuIoyXCHbMaXB/96KTHRz/f79yfnyewrUyw8t2dZP
tjG5YkDHTD+qVsBVoew3JIg7ZUBAj9wT/ch+4tPmJAalEF+ohGJ1WkasaLsXpSz8
jtplYmKE4ua8DP5FOqvvgdpQqjl7ywVXtWePNyjmfbR622RNFjEFjWIuMr9pgAwq
CWM5ijAj3zonRKy+sOzDWQne/90hbqgYzY7DE/muq23Iln4LYb2rt5d9Gjlro8a1
Bcx+4ZRhpvczG/la7I9w3j4X0gKFlB1qSd/nntodvmm+/IGHGwt1nJtAkRroLtdK
lXsOmrnbnCMjk38u0a7z
=f6Bf
-----END PGP SIGNATURE-----

--Apple-Mail=_2819A333-EE9E-433F-9391-3AB3E290FC11--

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5CEF44A4-3121-4A16-AB52-84CACB3F2C7F>