Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 03 Sep 2019 14:06:40 -0000
From:      Chris Rees <crees@bayofrum.net>
To:        rgrimes@freebsd.org, "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>, Chris Rees <chris@rees.space>, jilles@freebsd.org
Cc:        Andriy Gapon <avg@freebsd.org>, "O. Hartmann" <ohartmann@walstatt.org>, Chris Rees <crees@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r346017 - in head: libexec/rc libexec/rc/rc.d share/man/man5
Message-ID:  <95242E98-E578-476E-AFA6-099F00AF50BC@bayofrum.net>
In-Reply-To: <2B336327-528C-4E16-AA5D-B3497B1941D0@bayofrum.net>
References:  <201904092108.x39L8ZCG062247@gndrsh.dnsmgr.net> <2B336327-528C-4E16-AA5D-B3497B1941D0@bayofrum.net>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi again,

On 9 April 2019 22:13:29 BST, Chris Rees <crees@bayofrum.net> wrote:
>
>
>On 9 April 2019 22:08:35 BST, "Rodney W. Grimes"
><freebsd@gndrsh.dnsmgr.net> wrote:
>>> On 09/04/2019 20:59, Chris Rees wrote:
>>> > On 9 April 2019 20:55:07 BST, "Rodney W. Grimes"
>><freebsd@gndrsh.dnsmgr.net> wrote:
>>> >>> On 09/04/2019 21:33, Rodney W. Grimes wrote:
>>> >>>> I think the trigger issue is:
>>> >>>> grep zfs /etc/rc.d/zvol
>>> >>>> rcvar=3D"zfs_enable"
>>> >>>> required_modules=3D"zfs"
>>> >>>>
>>> >>>> that module requires may be going south with the
>>> >>>> new code when the module is built into the kernel.
>>> >>> Maybe it's because the module's name is zfsctrl (for whatever
>>reason)
>>> >> while the
>>> >>> module file is named zfs.ko.
>>> >> I suspect that could also lead to issues with the new code.
>>> >> It seems to be failing to detect that zfs is infact functional in
>>the
>>> >> kernel,
>>> >> and blindly, or not so blindly, trying to load zfs,ko, which when
>>you
>>> >> build
>>> >> it into the kernel you usually do so without any modules built,
>so
>>> >> there is
>>> >> no /boot/kernel/zfs.ko, and even if you did build it any attempt
>>to
>>> >> load
>>> >> it would return an error.
>>> > Loading with it built in isn't a problem, as I showed earlier.
>>> >
>>> > Loading when it doesn't exist *is*.
>>> >
>>> > I'm torn.  Either we could revert this, or add a check to the
>>required_modules function instead, which I think is the better
>>solution.
>>>=20
>>> Hang on,
>>>=20
>>> [crees@pegasus]~% sudo kldload -n zfsctrl && echo yes
>>> yes
>>
>>I think your testing the return value of sudo here?
>
>Sudo returns the child's return value.
>

Turns out Oliver had also reported this to current@ with a log

https://lists.freebsd.org/pipermail/freebsd-current/2019-April/073148.html

Jilles@, mind if I revert this while I get some testing on this scenario do=
ne?

It seems to me that zfs may not be included in the kernel, just zfsctrl, or=
 something like that.

Chris
--=20
Sent from my Android device with K-9 Mail. Please excuse my brevity.

--=20
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.






Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?95242E98-E578-476E-AFA6-099F00AF50BC>