Date: Tue, 15 Dec 2020 15:33:09 +0100 From: Hans Petter Selasky <hps@selasky.org> To: Mark Johnston <markj@freebsd.org> Cc: Bryan Drewery <bdrewery@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r368523 - head/sys/vm Message-ID: <d4c78af3-e5c0-417f-1042-a0a7cf27d523@selasky.org> In-Reply-To: <X9jH20xQcS72vuDQ@raichu> References: <202012102044.0BAKiTHh011767@repo.freebsd.org> <a5b983ca-73f6-a7eb-7b96-bb361c1a8514@selasky.org> <X9jH20xQcS72vuDQ@raichu>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/15/20 3:27 PM, Mark Johnston wrote:
>> I'm seeing the following panic:
>>
>> panic("vm_wait in early boot")
>> vm_wait_domain()
>> kmem_alloc_contig_pages()
>> kmem_alloc_contig_domainset()
>> kmem_alloc_contig()
>> contigmalloc()
>> x86bios_alloc()
>> vesa_configure()
>> vesa_mod_event()
>> vesa_module_register_init()
>> mi_startup()
> Is it on a NUMA system? I see that the new logic won't work properly if
> there are empty domains, so this suggests that we really do need a
> special contig iterator as discussed in the review.
Yes, this is a numa system.
I just noticed, that before r368523 "flags" was updated by
_vm_domainset_iter_policy_init() to always contain M_NOWAIT and that
avoids the wait logic, but I think x86bios_alloc() doesn't get its
memory then.
I'm not sure if x86bios_alloc() needs to be attached a bit later anyway?
--HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d4c78af3-e5c0-417f-1042-a0a7cf27d523>