Date: Fri, 27 Feb 2026 12:44:34 -0800 From: "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Michael Tuexen <tuexen@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 454212b9718b - main - sctp: fix so_proto when peeling off a socket Message-ID: <DCEDEFA3-EE75-46B1-9196-79B9173294A6@gmail.com> In-Reply-To: <320FFBF5-040E-4EA7-A960-8DC3A632744B@FreeBSD.org> References: <699ef25d.42e41.7579887f@gitrepo.freebsd.org> <DA9B5022-602F-4720-9473-191B1A20B6B5@gmail.com> <320FFBF5-040E-4EA7-A960-8DC3A632744B@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > On Feb 26, 2026, at 11:57 PM, Michael Tuexen <tuexen@FreeBSD.org> wrote: > >> On 27. Feb 2026, at 04:46, Enji Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote: >> >> Hi Michael! >> >>> On Feb 25, 2026, at 5:00 AM, Michael Tuexen <tuexen@FreeBSD.org> wrote: >>> >>> The branch main has been updated by tuexen: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=454212b9718b55b43781f81bef252658e20e0fd3 >> >> … >> >>> @@ -171,7 +173,7 @@ sys_sctp_peeloff(struct thread *td, struct sctp_peeloff_args *uap) >>> td->td_retval[0] = fd; >>> >>> CURVNET_SET(head->so_vnet); >>> - so = sopeeloff(head); >>> + so = sopeeloff(head, &sctp_stream_protosw); >> >> >> This part of the change broke LINT-NOINET because sctp_stream_protosw is only defined in the INET case. I didn’t dig into the SCTP syscalls too far, but I think that the right protocol needs to be picked per the address family, right? > Fixed in > https://cgit.FreeBSD.org/src/commit/?id=6bd97e9e01ff159eef49b2521fdbe67d5db10d95 <https://cgit.freebsd.org/src/commit/?id=6bd97e9e01ff159eef49b2521fdbe67d5db10d95>; > > Thanks again for reporting and sorry for breaking the build. No problemo! Thank you for fixing the issue so promptly :)!!! Hopefully `make tinderbox` is clean again now (on amd64/arm64 at least) :D.. -Enji [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmmiAjIACgkQGpE5DjPs NJiBTg/+PhtLgpUnJedbK+kWQr/McI/XKz8Ua5k9nAFQ+5mCJhM8xIQW33SZBq5f Ad51yfoyjfnDuTpU7i4QaOGfGZTwcPW2TCeqNlxLpUsWTf5Fn5WwIZMe4nkkIibG ua8+3N+8rWYMvR0XNEaGhLSqfQUXo62unuR7dM7dnRBAhlrFtemaEsP/gSDgtUwJ RuUc0wxPpR3NqBa6+6rWgRI9DR1ERLPfBPedGFA5OfiAX/sILLsqqo5WbunBIbym Duqr99PWcBW1VeOu9XcQpjaEcH5P6Sg6H65HBokXkNwAAaQIdsH4miT9YEZ/2b0T vtpAxVq4g9Srz8tOpfUTrlFwzjczm3cZ8KL3TNUfdp0E9nJuKQ9sCR6kJGn8kqiq vwS8BMv1n3rd+4jsiOPGooL0PpOi2oXya8UD/vtA6vv+m3NFWbpt4ZNBNwZXYcOb CY4FMxm23O4tGyp6U6bTHKhjYfST93rCEYJmxpKHBhwD13p6Ma+iKED8gPOy2+B2 lZPjnUVfTo+nT4JT3WZbgR4hLKU/YUisppbb1LHMflzELc0u+FWIl+cKjtQp6/Ny 8TQznn/pBi5q+Ql2DL/TvplQRSXFTgdb/q5XQiDBJH9R+zLQlgbWe3KAVmvVmItu 5RsFXfznDlWsq8ZZezON5t9TB0YbpTyi4QtveUSqH6drRLdtQuI= =zNhk -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DCEDEFA3-EE75-46B1-9196-79B9173294A6>