Date: Fri, 14 Apr 2017 14:14:16 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Maxim Sobolev <sobomax@sippysoft.com> Cc: Peter Wemm <peter@wemm.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Hiren Panchasara <hiren@freebsd.org>, Hiroki Sato <hrs@FreeBSD.org> Subject: Re: svn commit: r316874 - head/sys/kern Message-ID: <C976394B-87C9-40E5-A66D-951B77D7982D@gmail.com> In-Reply-To: <CAH7qZfvPQpmTkypWdv1K=9yKF6was1sXuXY7McAeTrC8mvYZbg@mail.gmail.com> References: <201704141723.v3EHNS3B043902@repo.freebsd.org> <12133324.zHp9vo75vZ@overcee.wemm.org> <CAH7qZfuxM2pWvPh-LGP8_vrSpm==hTCWjnoZoXSvaFSgAaS8pg@mail.gmail.com> <6942092.OsECkgAp13@overcee.wemm.org> <513B1846-02E3-49E0-BAA2-CA923EDC5DFF@gmail.com> <CAH7qZfvPQpmTkypWdv1K=9yKF6was1sXuXY7McAeTrC8mvYZbg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_33D0C2FF-AD51-4BEE-9D9E-6749C1E773C8 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Apr 14, 2017, at 14:10, Maxim Sobolev <sobomax@sippysoft.com> = wrote: >=20 > Peter, Ngie, >=20 > Looks like out of that refactoring came a logical bug that is present = in the head, which causes syslod to first to shutdown the socket for = reading and then try to select/recv on it (which is somewhat stupid). = And that issue has been masked by shutdown() on datagram socket becoming = effectively a NOP in 11 & head 20 months ago. It only affects head = though, 11-stable still has the old code which does not include that = half-closed socket into the select list. Attached patch is expected to = fix head, Peter, it would be nice if you can give it a try (restoring = latest changes into uipc_sockets.c) and let me know if it helps. >=20 > Thanks! CCing hrs@ for input as he did the refactoring. Thanks! -Ngie PS LGTM with the change. Will wait for feedback from wemm@. --Apple-Mail=_33D0C2FF-AD51-4BEE-9D9E-6749C1E773C8 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJY8TupAAoJEPWDqSZpMIYVO/0QAJT8tq4nDLxs65X7lQ2HjOlk v+ba03skz4hkhPU2k3N1sz67CuwFvsqFzlyu1wARBEje5yD1urBy7w6pKNQZbiYi jYdT78AE4q40XZU6XBD7Ne94BSczTe4uI8lfU3VMpv+Fnb1bL54HJ1MFUpTY4IZs KO1/CMv7XOqwuNiZDE2WFFEfTJQIB+JB/tgdQTiW3Aac7XNHiXS7i7hHC4WFp7Vi lsMZ/VGI0Umx6gvOmoimpjAK1fL2QbDh/JHDnklhm3evdIVSiS7cv9cOf+DZMsEH p8iJMHO8x7H4JVvAbJMBLZpLFDCfm47HMkDJZxaZAGhIWN43acefYgDaFnxk6oXt UJL4FoBF8XyTaHevv8Y/3KuxsBRHio36GpSpQ7/EbTw9TielxqZkUlXLAuQThtUt CsAXktFGZa3DAuOQ23/VXx0tTazNwfNuZalnIzaNfAIjCDv5K1Y0xXlz8yJqhmOe QTUOCt5Jz3M1XHhX9fGmx36utuMbavLPvhVEsueQ0JEDGhKXSBlxNIN6XB85YU29 c25O1PkvbcTlBppCMCshAONDcuSBqdjpUGbzPQmv5PXFO+IhNetQHu9PnayLbDNY JCKXIPATL1ZS28xZGASHORSe1oFze30OG5y18O2FbpUOoyDR2m9oOPjDlBZKVRcz qpJ2cJK2xWX7AD0tv3LW =aXDt -----END PGP SIGNATURE----- --Apple-Mail=_33D0C2FF-AD51-4BEE-9D9E-6749C1E773C8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C976394B-87C9-40E5-A66D-951B77D7982D>