Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 25 Aug 2003 12:03:50 -0700
From:      Marcel Moolenaar <marcel@xcllnt.net>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/vm vm_page.h
Message-ID:  <20030825190349.GC18841@ns1.xcllnt.net>
In-Reply-To: <XFMail.20030825133836.jhb@FreeBSD.org>
References:  <200308230624.h7N6O0bq088622@repoman.freebsd.org> <XFMail.20030825133836.jhb@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Aug 25, 2003 at 01:38:36PM -0400, John Baldwin wrote:
> 
> On 23-Aug-2003 Marcel Moolenaar wrote:
> > marcel      2003/08/22 23:24:00 PDT
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/vm               vm_page.h 
> >   Log:
> >   Add support for 16K and 32K page sizes. The valid and dirty maps
> >   in struct vm_page are defined as u_int for 16K pages and u_long
> >   for 32K pages, with the implied assumption that long will at least
> >   be 64 bits wide on platforms where we support 32K pages.
> 
> Why not use 'uint32_t' and 'uint64_t' to remove the assumption?

I thought about that but decided not to do it because it would
introduce a style variation that I considered worse than having
the implied assumption.

-- 
 Marcel Moolenaar	  USPA: A-39004		 marcel@xcllnt.net



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030825190349.GC18841>