Date: Sat, 14 Dec 2019 12:27:59 -0700 From: Warner Losh <imp@bsdimp.com> To: Pedro Giffuni <pfg@freebsd.org> Cc: Ryan Libby <rlibby@gmail.com>, Conrad Meyer <cem@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r355747 - in head: . include lib/libc/stdlib lib/libxo Message-ID: <CANCZdfqmB%2BD=4Od-Z%2BYoP=-ds106vJhOUaxY9i478neNpXDrwQ@mail.gmail.com> In-Reply-To: <7d4c68ec-97e9-8b29-ac70-f8167f31de37@FreeBSD.org> References: <201912140828.xBE8SAXq027656@repo.freebsd.org> <CAHgpiFyQ6%2B-cbjtwi6NsPkohbQd%2B6ies0%2B55g5KtYH9Pog_sTw@mail.gmail.com> <7d4c68ec-97e9-8b29-ac70-f8167f31de37@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Dec 14, 2019 at 12:22 PM Pedro Giffuni <pfg@freebsd.org> wrote: > > On 14/12/2019 13:20, Ryan Libby wrote: > > On Sat, Dec 14, 2019 at 12:28 AM Conrad Meyer <cem@freebsd.org> wrote: > >> Author: cem > >> Date: Sat Dec 14 08:28:10 2019 > >> New Revision: 355747 > >> URL: https://svnweb.freebsd.org/changeset/base/355747 > >> > >> Log: > >> Deprecate sranddev(3) API > >> > >> It serves no useful purpose and wasn't as popular as its equally > meritless > >> cousin, srandomdev(3). > >> > >> .. (cut unrelated code) > >> > >> Modified: head/include/stdlib.h > >> > ============================================================================== > >> --- head/include/stdlib.h Sat Dec 14 05:21:56 2019 > (r355746) > >> +++ head/include/stdlib.h Sat Dec 14 08:28:10 2019 > (r355747) > >> @@ -309,12 +309,17 @@ int rpmatch(const char *); > >> void setprogname(const char *); > >> int sradixsort(const unsigned char **, int, const unsigned char *, > >> unsigned); > >> -void sranddev(void); > >> void srandomdev(void); > >> long long > >> strtonum(const char *, long long, long long, const char **); > >> > >> /* Deprecated interfaces, to be removed. */ > >> +static inline void > >> +__attribute__((__deprecated__("sranddev to be removed in FreeBSD 13"))) > >> +sranddev(void) > >> +{ > >> +} > >> + > > This broke some gcc builds in ci. It looks like older versions of gcc > > don't like having an argument to deprecated. > > FWIW, the msg argument for __deprecated__ appeared in GCC 4.5. > Maybe sys/cdefs.h should define a __DEPRECATED for such differences? It's not like __attribute__ is a standard thing anyway... Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqmB%2BD=4Od-Z%2BYoP=-ds106vJhOUaxY9i478neNpXDrwQ>